gh-154279: Skip readline completion tests that fail on DragonFly and illumos#154280
Merged
serhiy-storchaka merged 1 commit intoJul 20, 2026
Conversation
…y and illumos They are already skipped on FreeBSD, where a backspace does not remove the auto-indentation. The same happens on DragonFly and illumos. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
requested review from
erlend-aasland and
gaogaotiantian
as code owners
July 20, 2026 18:02
serhiy-storchaka
added
skip news
3.14
serhiy-storchaka
added
needs backport to 3.14
serhiy-storchaka
enabled auto-merge (squash)
July 20, 2026 18:04
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-154282 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-154288 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 21, 2026
…ly and illumos (GH-154280) (GH-154282) They are already skipped on FreeBSD, where a backspace does not remove the auto-indentation. The same happens on DragonFly and illumos. (cherry picked from commit e81f190) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These readline completion tests are already skipped on FreeBSD (gh-133558), where a backspace does not remove the auto-indentation in the pseudo-terminal opened by
run_pty(). The same failures occur on DragonFly and illumos, so extend the skips.NetBSD and OpenBSD are not affected.