setuptools & distutils: ClassVar mutables (and tuples)
#12403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
approved these changes
Jul 22, 2024
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Skimming through this: LGTM
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
mypy_primer looks like a true-positive due to runtime backwards compatibility (that requires a @srittau I reset your review since I included a few additional lines right afterward. |
This comment has been minimized.
This comment has been minimized.
max-muoto
reviewed
Jul 22, 2024
stubs/setuptools/setuptools/msvc.pyi
Outdated
| class RegistryInfo: | ||
| HKEYS: Incomplete | ||
| if sys.platform == "win32": | ||
| HKEYS: ClassVar[tuple[int, int, int, int]] |
Contributor
There was a problem hiding this comment.
Any reason not to use Final here? It would effectively interpreted as an immutable ClassVar here.
Collaborator
Author
There was a problem hiding this comment.
I think this can be made Final. I doubt it's meant to be overridden by subclasses
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 22, 2024
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: setuptools (https://github.com/pypa/setuptools)
+ setuptools/command/__init__.py:6: error: No overload variant of "__setitem__" of "list" matches argument types "str", "Tuple[str, str]" [call-overload]
+ setuptools/command/__init__.py:6: note: Possible overload variants:
+ setuptools/command/__init__.py:6: note: def __setitem__(self, SupportsIndex, str, /) -> None
+ setuptools/command/__init__.py:6: note: def __setitem__(self, slice, Iterable[str], /) -> None
|
srittau
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the type for all class-level dicts, lists and tuples that I found.
Reduces changes in #12400
Reduces bare
Any(#9550)