-
-
Notifications
You must be signed in to change notification settings - Fork 133
Remove no_type_check_decorator from _typing_names #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #723 +/- ##
==========================================
- Coverage 97.38% 96.74% -0.64%
==========================================
Files 3 3
Lines 7689 7690 +1
==========================================
- Hits 7488 7440 -48
- Misses 201 250 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Co-authored-by: Alex Waygood <[email protected]>
|
This is technically a breaking change. I wonder whether we shouldn't add a small stub for this for Python 3.15+, so that importing that name doesn't break. |
|
Since this was never implemented by any type checkers as far as I know, we could even skip the import for all Python versions and just add something like (pseudo-code): def __getattr__(name):
if name == "no_type_check_decorator":
# print deprecation warning
return lambda f: for just @deprecated("...")
def no_type_check_decorator(f):
return f |
|
I think this is fine as is. It's OK if behavior changes depending on the Python version. |
Resolves: #700
Tested with 3.15.0a4