Migrate TBE benchmark type imports to fbgemm_gpu.tbe.* leaves (Phase 3.7) - #6060
Open
q10 wants to merge 1 commit into
Open
Migrate TBE benchmark type imports to fbgemm_gpu.tbe.* leaves (Phase 3.7)#6060q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
…3.7)
Summary:
Continues the Chunk H consumer migration: point the fbgemm_gpu benchmark
scripts at the canonical fbgemm_gpu.tbe.* leaf modules instead of the legacy
split_table_batched_embeddings_ops_common re-export shim.
Identity-preserving: split_table_batched_embeddings_ops_common already
re-exports these exact symbols from the same leaves, so importing directly
yields the same objects.
Files (10):
- bench/merge_embeddings_benchmark.py
- bench/tbe/{split_table_batched_embeddings,tbe_cache,tbe_inference,tbe_kv,tbe_ssd,tbe_training,tbe_utils}_benchmark.py
- fb/bench/split_table_batched_embeddings_benchmark_fb.py
- fb/triton/bench/triton_table_batched_embeddings_bench.py
Note: tbe_utils_benchmark.py keeps its generate_vbe_metadata import from
split_table_batched_embeddings_ops_training_common (that leaf, tbe/operators/vbe.py,
is a later chunk).
Reviewed By: henrylhtsang
Differential Revision: D112765163
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112765163. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Continues the Chunk H consumer migration: point the fbgemm_gpu benchmark
scripts at the canonical fbgemm_gpu.tbe.* leaf modules instead of the legacy
split_table_batched_embeddings_ops_common re-export shim.
Identity-preserving: split_table_batched_embeddings_ops_common already
re-exports these exact symbols from the same leaves, so importing directly
yields the same objects.
Files (10):
Note: tbe_utils_benchmark.py keeps its generate_vbe_metadata import from
split_table_batched_embeddings_ops_training_common (that leaf, tbe/operators/vbe.py,
is a later chunk).
Reviewed By: henrylhtsang
Differential Revision: D112765163