Add grid-stride + ROCm cap to grad_mean kernel - #6078
Open
q10 wants to merge 1 commit into
Open
Conversation
Summary:
The MEAN-pooling TBE backward launches grad_mean{,_vbe}_kernel with
grid = div_round_up(total_B, kMaxThreads / grad_mean_warp_size) and
block = dim3(grad_mean_warp_size, kMaxThreads / grad_mean_warp_size)
(total_B = B * T), so total threads ~= total_B * grad_mean_warp_size exceeds
the HIP 2^32 threads-per-launch limit on ROCm for large total_B.
Cap the launch with utils::cuda::cap_grid_dim_x(..., OverflowOnly) and add a
ROCm grid-stride loop over b_t to the kernel (no internal early-returns; single
guard converted to the loop bound). No-op on CUDA.
Reviewed By: cthi
Differential Revision: D113351689
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113351689. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The MEAN-pooling TBE backward launches grad_mean{,_vbe}_kernel with
grid = div_round_up(total_B, kMaxThreads / grad_mean_warp_size) and
block = dim3(grad_mean_warp_size, kMaxThreads / grad_mean_warp_size)
(total_B = B * T), so total threads ~= total_B * grad_mean_warp_size exceeds
the HIP 2^32 threads-per-launch limit on ROCm for large total_B.
Cap the launch with utils::cuda::cap_grid_dim_x(..., OverflowOnly) and add a
ROCm grid-stride loop over b_t to the kernel (no internal early-returns; single
guard converted to the loop bound). No-op on CUDA.
Reviewed By: cthi
Differential Revision: D113351689