Improve benchmark installation speed#2683
Improve benchmark installation speed#2683benjaminglass1 wants to merge 1 commit intopytorch:mainfrom
Conversation
|
Test failures look the same as those on |
This solves a problem noticed while installing benchmarks and watching htop. A significant amount of time per installation is wasted checking package version that have already been checked. This commit caches those versions.
22ab4a1 to
b97ab5a
Compare
|
@xmfan Please take a second look, I had to rewrite this after realizing this function is also used to validate that package versions haven't changed after installing benchmarks (which caching would invalidate). Currently getting some timing runs, but I still expect roughly the same speedup. |
|
On my machine, installing all benchmarks on The main reason for this is that we checked the version of several dependencies twice per benchmark. We got the version by importing the package in a new subprocess and querying |
This solves a problem noticed while installing benchmarks and watching htop. A significant amount of time per installation is wasted checking package version that have already been checked. This PR caches those versions.
I also fixed one or two minor Ruff lints in the files I touched.