This repository was archived by the owner on Apr 1, 2021. It is now read-only.
Open
Conversation
yinghai
approved these changes
Aug 20, 2019
|
|
||
| auto transpose_attrs = tvm::make_node<tvm::relay::TransposeAttrs>(); | ||
| auto& axes = transpose_attrs->axes; | ||
| axes.push_back(0); |
kimishpatel
force-pushed
the
lower_batch_matmul
branch
from
ea2cdd9 to
2dba17a
Compare
Contributor
Author
|
Hmm, let me try with updating ci config. Thanks for the link.
From: Yinghai Lu <notifications@github.com>
Reply-To: pytorch/tvm <reply@reply.github.com>
Date: Tuesday, August 20, 2019 at 1:50 PM
To: pytorch/tvm <tvm@noreply.github.com>
Cc: Kimish Patel <kimishpatel@fb.com>, Author <author@noreply.github.com>
Subject: Re: [pytorch/tvm] Map batch matmul from PT to TVM. (#95)
Regarding the error: https://stackoverflow.com/questions/34819221/why-is-python-setup-py-saying-invalid-command-bdist-wheel-on-travis-ci<https://urldefense.proofpoint.com/v2/url?u=https-3A__stackoverflow.com_questions_34819221_why-2Dis-2Dpython-2Dsetup-2Dpy-2Dsaying-2Dinvalid-2Dcommand-2Dbdist-2Dwheel-2Don-2Dtravis-2Dci&d=DwMCaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=fnncU1KylaEiKyqiohSbhNpassAIOcfsTdnJB1l3C2M&m=5tLmVEBne0DABRuy45PoNFfg9WQAJB1UJFr6cFM-Goc&s=-k_btIbFPZiAwncEeK5r6Q6MA52f3S5n-QhfjxvgB7s&e=>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#95?email_source=notifications&email_token=AEFNYVI356LXONDQAOKZQZTQFRKFNA5CNFSM4INYQBV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4XTUHI#issuecomment-523188765>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEFNYVNOW2NHMGVYZUWIDFTQFRKFNANCNFSM4INYQBVQ>.
|
|
Hmm, try rebasing and it should work. |
Also added test. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
kimishpatel
force-pushed
the
lower_batch_matmul
branch
from
2dba17a to
e598e92
Compare
|
Rebase to master and we should expect CI to pass. |
Contributor
Author
|
This one is causing some correctness issues when run with bert model, even though unit tests pass. So I need to do some investigation before pushing it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added test.
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: