Repository navigation
fix(release): skip tagging when the release tag already exists on HEAD - #326
Merged
Merged
Conversation
The v* tag ruleset lets only cloud-admins create tags, so a cloud-admin pushes the release tag ahead of the release run. The workflow then finds the tag on HEAD and continues instead of failing; a tag on a different commit still fails the release.
ssyno
force-pushed
the
fix/spyros/release-tag-idempotent
branch
from
October 19, 2026 14:18
daf820a to
d0a1d7f
Compare
superseb
requested changes
Oct 20, 2026
superseb
left a comment
superseb
left a comment
Contributor
There was a problem hiding this comment.
This PR only focuses on the technical issue with the new way of working with tags for this repository. But the most important part is the way of working, as it is expected for a cloud-admin to tag and push the tag before running this workflow, right?
The README.md contains how to release, it should be updated together with this so it is clear to everyone.
Contributor
Author
|
Fair point, added. README now has the full flow: branch locally, cloud-admin tags the commit and pushes the tag, then push the release branch. Also what happens if the branch goes first: run fails at the tag step, push the tag, re-run the failed job. |
superseb
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The release workflow's tag step now checks the remote first. Tag absent: create and push as before. Tag present on HEAD, lightweight or annotated: skip. Tag present on another commit: fail the release.
Why
The SEC-43 tag ruleset lets only cloud-admins create
v*tags, and this workflow pushed the tag itself with the Actions token, so the next release would fail at that step. kubernetes-api keeps thevprefix because it is a Go module consumed by operator, qdrant-cloud-agent and qdrant-private-cloud. Until a release App exists, a cloud-admin pushes the tag ahead of the release run and the workflow continues from there. Interim fix agreed with Alex in the SEC-41 thread.