Skip to content

Test commit for Compilation issue - #62

Open
sgaud-quic wants to merge 620 commits into
qcom-next-stagingfrom
sgaud-quic-patch-32
Open

Test commit for Compilation issue#62
sgaud-quic wants to merge 620 commits into
qcom-next-stagingfrom
sgaud-quic-patch-32

Conversation

@sgaud-quic

Copy link
Copy Markdown
Collaborator

No description provided.

sgaud-quic and others added 30 commits March 23, 2026 12:36
This reverts commit 09ed0b6.

Issue is observed with this commit 09ed0b6 leading to crash,
with following call stack

[   19.706310][   T73] Call trace:
[   19.706312][   T73]  usb_role_switch_unregister+0x28/0x70 (P)
[   19.706319][   T73]  eud_role_switch_release+0x30/0x78 [qcom_eud]
[   19.884972][   T73]  devm_action_release+0x1c/0x30
[   19.884981][   T73]  release_nodes+0x70/0x120
[   19.884987][   T73]  devres_release_all+0x98/0xf0
[   19.884995][   T73]  device_unbind_cleanup+0x20/0x98
[   19.885000][   T73]  really_probe+0x184/0x3f0
[   19.885005][   T73]  __driver_probe_device+0x88/0x190
[   19.885010][   T73]  driver_probe_device+0x44/0x120
[   19.885015][   T73]  __device_attach_driver+0xc4/0x178
[   19.885020][   T73]  bus_for_each_drv+0x90/0xf8
[   19.885027][   T73]  __device_attach+0xa8/0x1d8
[   19.885032][   T73]  device_initial_probe+0x58/0x68
[   19.885037][   T73]  bus_probe_device+0x40/0xb8
[   19.885041][   T73]  deferred_probe_work_func+0xbc/0x128
[   19.885046][   T73]  process_one_work+0x180/0x450
[   19.885055][   T73]  worker_thread+0x26c/0x388
[   19.885062][   T73]  kthread+0x120/0x140
[   19.885068][   T73]  ret_from_fork+0x10/0x20
[   19.885079][   T73] Code: f9000bf3 aa0003f3 b140041f 54000168 (390c901f)
[   19.885083][   T73] ---[ end trace 0000000000000000 ]---
[   19.885088][   T73] Kernel panic - not syncing: Oops: Fatal exception
[   19.885091][   T73] SMP: stopping secondary CPUs

Revert commit for now.

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
… block

The APSS debug block is built with CoreSight devices like ETM,
replicator, funnel and TMC ETF. Add dt nodes for these devices to enable
ETM trace.

Link: https://lore.kernel.org/all/20251218-cpu_cluster_component_pm-v2-12-2335a6ae62a0@oss.qualcomm.com/
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Co-developed-by: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Signed-off-by: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Embedded Trace Router(ETR) is working as a DDR memory sink to collect
tracing data from source device.

The CTCU serves as the control unit for the ETR device, managing its
behavior to determine how trace data is collected.

Link: https://lore.kernel.org/all/20260204-enable-ctcu-and-etr-v3-2-0bb95c590ae1@oss.qualcomm.com/
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Document the device tree bindings for the PURWA-IOT-EVK board, which
uses the Qualcomm X1P42100 SoC.

Link: https://lore.kernel.org/all/20260202073555.1345260-1-yijie.yang@oss.qualcomm.com/
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
Add the Purwa-IoT-EVK board to the list to enable access to EFI variables.

Guarantee that subsystems relying on SCM services can access secure-world
features. This change improves reliability and prevents missing
functionality or boot-time issues by making service availability explicit.

Link: https://lore.kernel.org/all/20260202073555.1345260-2-yijie.yang@oss.qualcomm.com/
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
The PURWA-IOT-SOM is a compact computing module that integrates a System
on Chip (SoC) — specifically the x1p42100 — along with essential
components optimized for IoT applications. It is designed to be mounted on
carrier boards, enabling the development of complete embedded systems.

Purwa uses a slightly different Iris HW revision (8.1.2 on Hamoa, 8.1.11 on
Purwa). Support will be added later.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe3, PCIe4, PCIe5, PCIe6a
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic

Link: https://lore.kernel.org/all/20260202073555.1345260-3-yijie.yang@oss.qualcomm.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of
the Purwa IoT SoM and a carrier board. Together, they form a complete
embedded system capable of booting to UART.

PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK.
Meanwhile, USB0 bypasses the SBU selector FSUSB42.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio
- PCIe ports for PCIe3 through PCIe6a
- TPM

Link: https://lore.kernel.org/all/20260202073555.1345260-4-yijie.yang@oss.qualcomm.com/
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
Add UFS host controller and PHY nodes for x1e80100 SoC.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Link:
https://lore.kernel.org/all/20260211132926.3716716-1-pradeep.pragallapati@oss.qualcomm.com
Enable UFS for HAMOA-IOT-EVK board.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Link:
https://lore.kernel.org/all/20260211132926.3716716-1-pradeep.pragallapati@oss.qualcomm.com
…t evk board

Enable SD Card host controller for hamoa iot evk board.

Link:
https://lore.kernel.org/all/20260211093045.2595126-1-sarthak.garg@oss.qualcomm.com/
Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Add DAI links for DP0 and DP1 playback and set sound-name-prefix
for both DisplayPort endpoints in the hamoa-evk DTS.

Link: https://lore.kernel.org/all/20260209091139.622756-1-le.qi@oss.qualcomm.com/
Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Add the CAMCC block for x1e80100. The x1e80100 CAMCC block is an iteration
of previous CAMCC blocks with the exception of having two required
power-domains not just one.

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260128-purwa-videocc-camcc-v1-6-b23de57df5ba@oss.qualcomm.com
…odes on purwa

Update the compatible for videocc and camcc nodes to match with their
respective purwa(X1P42100) specific drivers.

Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260128-purwa-videocc-camcc-v1-7-b23de57df5ba@oss.qualcomm.com
Enable passive cooling for CPUs in the X1E80100 SoC by adding the
'#cooling-cells' property. This will allow the OS to mitigate the CPU
power dissipation with the help of SCMI DVFS.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Tested-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260210070321.17033-1-manivannan.sadhasivam@oss.qualcomm.com
Add support for SYSTEM_RESET2 vendor-specific resets as
reboot-modes in the psci node.  Describe the resets: "bootloader"
will cause device to reboot and stop in the bootloader's fastboot
mode.  "edl" will cause device to reboot into "emergency download
mode", which permits loading images via the Firehose protocol.

Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260226054113.4156874-1-xin.liu@oss.qualcomm.com/
Add support for building an EL2 combined DTB for the hamoa-evk
in the Qualcomm DTS Makefile.

The new hamoa-iot-evk-el2.dtb is generated by combining the base
hamoa-iot-evk.dtb with the x1-el2.dtbo overlay, enabling EL2-specific
configurations required by the platform.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260127062425.1084673-1-xin.liu@oss.qualcomm.com/
…e trees

All the existing variants Hamoa boards are using Gunyah hypervisor
which means that, so far, Linux-based OS could only boot in EL1 on
those devices. However, it is possible for us to boot Linux at EL2
on these devices [1].

When running under Gunyah, the remote processor firmware IOMMU streams
are controlled by Gunyah. However, without Gunyah, the IOMMU is managed
by the consumer of this DeviceTree. Therefore, describe the firmware
streams for each remote processor.

Add remoteproc IOMMUS to the EL2 device trees to generate the
corresponding -el2.dtb files.

[1]
https://docs.qualcomm.com/bundle/publicresource/topics/80-70020-4/boot-developer-touchpoints.html#uefi

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260203063244.1498699-1-xin.liu@oss.qualcomm.com/
Add in two CCI buses.

One bus has two CCI bus master pinouts:
cci_i2c_sda0 = gpio101
cci_i2c_scl0 = gpio102

cci_i2c_sda1 = gpio103
cci_i2c_scl1 = gpio104

The second bus has two CCI bus master pinouts:
cci_i2c_sda2 = gpio105
cci_i2c_scl2 = gpio106

aon_cci_i2c_sda3 = gpio235
aon_cci_i2c_scl3 = gpio236

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Tested-by: Christopher Obbard <christopher.obbard@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-2-f3f7ddfbf849@linaro.org/
Add csiphy nodes for

- csiphy0
- csiphy1
- csiphy2
- csiphy4

The irregular naming of the PHYs comes directly from the hardware which for
whatever reason skipped csiphy3.

Separating the nodes from CAMSS as we have done with the sensor I2C bus aka
the CCI interface is justified since the CSIPHYs have their own pinouts and
voltage rails.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Tested-by: Christopher Obbard <christopher.obbard@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-3-f3f7ddfbf849@linaro.org/
Add dtsi to describe the xe180100 CAMSS block

4 x CSIPHY
3 x TPG
2 x CSID
2 x CSID Lite
2 x IFE
2 x IFE Lite

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-4-f3f7ddfbf849@linaro.org/
…gulators

Add pmic,id = m rpmh to regulator definitions. This regulator set provides
vreg_l3m_1p8 the regulator for the ov08x40 RGB sensor on the CRD.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-5-f3f7ddfbf849@linaro.org/
…SIPHY4

Define ov08x40 on cci1_i2c1. The RGB sensor appears on the AON CCI pins
connected to CSIPHY4 in four lane mode.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-6-f3f7ddfbf849@linaro.org/
…h voltage levels for IR and RGB camera

Add the PM8010 PMIC providing the following voltage rails:

vreg_l1m_r @ 1v2 IR sensor
vreg_l2m_r @ 1v2 RGB sensor
vreg_l3m_r @ 1v8 IR sensor
vreg_l4m_r @ 1v8 RGB sensor
vreg_l5m_r @ 2v8 IR sensor
vreg_l7m_r @ 2v8 RGB sensor

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-7-f3f7ddfbf849@linaro.org/
…on CSIPHY4

Switch on the ov02c10 RGB sensor on CSIPHY4.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Tested-by: Christopher Obbard <christopher.obbard@linaro.org>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-8-f3f7ddfbf849@linaro.org/
…amera PMIC with voltage levels for IR and RGB camera

Add voltage regulators-8 for Camera on slim7x including:

- vreg_l7m_2p8
- vreg_l2m_1p2
- vreg_l4m_1p8

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Christopher Obbard <christopher.obbard@linaro.or>
Link: https://lore.kernel.org/all/20260226-x1e-camss-csi2-phy-dtsi-v1-9-f3f7ddfbf849@linaro.org/
Add pm8010 L4M regulator which is used by Camera I2C pull-up.

Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260227-hamoa_evk-v1-1-36f895a24d8f@oss.qualcomm.com/
Enable IMX577 via CCI on Hamoa EVK Core Kit.

The Hamoa EVK board does not include a camera sensor
by default, this DTSO has enabled the Arducam 12.3MP
IMX577 Mini Camera Module on the CSI-1 interface.

Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260227-hamoa_evk-v1-2-36f895a24d8f@oss.qualcomm.com/
…configuration

Hamoa IOT boards support a different thermal junction temperature
specification compared to the base Hamoa platform due to package
level differences.

Update the passive trip thresholds to 105°C to align with the higher
temperature specification.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/linux-devicetree/20260302-higher_tj-v1-1-4c0d288f8e7f@oss.qualcomm.com/
Add CoreSight nodes to enable trace paths like TPDM->ETF/STM->ETF.
These devices are part of the AOSS, CDSP, QDSS, PCIe5, TraceNoc and
some small subsystems, such as GCC, IPCC, PMU and so on.

Link: https://lore.kernel.org/all/20260318-add-coresight-dt-nodes-for-glymur-v2-1-d76e08f21fa5@oss.qualcomm.com/
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
… eDP PHY

The initial sa8775p eDP PHY binding contribution missed adding support for
voting on the eDP reference clock. This went unnoticed because the UFS PHY
driver happened to enable the same clock.

After commit 77d2fa5 ("scsi: ufs: qcom : Refactor phy_power_on/off
calls"), the eDP reference clock is no longer kept enabled, which results
in the following PHY power-on failure:

phy phy-aec2a00.phy.10: phy poweron failed --> -110

To fix this, explicit voting for the eDP reference clock is required.
This patch adds the eDP reference clock for sa8775p eDP PHY and updates
the corresponding example node.

Link: https://lore.kernel.org/all/20260128114853.2543416-2-quic_riteshk@quicinc.com/
Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
sgaud-quic and others added 22 commits April 3, 2026 11:39
# Conflicts:
#	drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
# Conflicts:
#	arch/arm64/configs/defconfig
Adding merge log file and topic_SHA1 file

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
…g/pub/scm/linux/kernel/git/torvalds/linux.git

Merge qcom-next based on tag 'Linux 7.0-rc6' of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git:

tech/bsp/clk 90af1d3 12
tech/bsp/interconnect 7d3a72c 5
tech/security/firmware-smc a50984a 2
tech/bsp/soc-infra c793ce5 5
tech/bsp/pinctrl 28c2b80 1
tech/bsp/remoteproc abb91ae 5
tech/bus/peripherals 8c19ed7 2
tech/bus/pci/all 6a697f8 6
tech/bus/pci/mhi fb9c163 1
tech/bus/pci/phy aaf8ef1 4
tech/bus/usb/dwc 49ac8e0 2
tech/bus/usb/phy 8c7f91d 35
tech/debug/hwtracing 87ae82d 31
tech/pmic/misc e6525e3 9
tech/pmic/regulator 81fc8fb 6
tech/mem/iommu 43dfdd1 4
tech/mm/audio/all d38b67b 14
tech/mm/camss ef80fad 20
tech/mm/drm b17e723 12
tech/mm/fastrpc c29b2a8 5
tech/mm/video fa0e482 4
tech/mm/gpu 9c8e55d 2
tech/net/ath f8562ba 2
tech/net/eth 49b156f 1
tech/net/qrtr 64d75f7 1
tech/net/phy a3602e9 1
tech/net/bluetooth 229e73e 3
tech/pm/power 25fc1b7 9
tech/pm/thermal d174ed3 6
tech/security/crypto a6ce790 12
tech/security/ice 5184a0e 15
tech/storage/all e254dae 1
tech/all/dt/qcs6490 5fb16ec 16
tech/all/dt/qcs9100 5586aac 19
tech/all/dt/qcs8300 37ae346 21
tech/all/dt/qcs615 367314f 27
tech/all/dt/agatti c828f10 1
tech/all/dt/hamoa 49fad94 32
tech/all/dt/glymur 3aa6f05 23
tech/all/dt/kaanapali 70486f2 23
tech/all/dt/pakala 86103bc 6
tech/all/config 9050b95 53
tech/overlay/dt bbed7cf 24
tech/all/workaround c3f9d3b 13
tech/mproc/all eabd91e 4
tech/noup/debug/all 342aeb8 15
tech/hwe/unoq 7d981fe 16
early/hwe/shikra/drivers 347ed44 25
early/hwe/shikra/dt 6ae20ad 15
… SM8650 G4 fix

Commit 81af9e4 ("phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4")
moved QPHY_V6_PCS_UFS_PLL_CNTL register configuration from the shared
sm8650_ufsphy_g5_pcs table to the SM8650-specific sm8650_ufsphy_pcs base
table to fix Gear 4 operation on SM8650.

However, this change inadvertently broke kaanapali and SM8750 SoCs
which also rely on the shared sm8650_ufsphy_g5_pcs table for Gear 5
configuration but use their own sm8750_ufsphy_pcs base table. After the
change, kaanapali PHYs are left without the required PLL_CNTL = 0x33
setting, causing the PHY PLL to remain at its hardware reset default
value, preventing PLL lock and resulting in DME_LINKSTARTUP timeouts.

Fix this by adding the missing QPHY_V6_PCS_UFS_PLL_CNTL = 0x33 entry
to the sm8750_ufsphy_pcs table, mirroring what the original commit
already did for sm8650_ufsphy_pcs.

Cc: stable@vger.kernel.org # v6.10
Fixes: 81af9e4 ("phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4")
Signed-off-by: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
Link:
https://lore.kernel.org/all/20260415104851.2763238-1-nitin.rawat@oss.qualcomm.com/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
…nto shared dtsi

The monaco-ac EVK is a new board variant which shares the majority of
its hardware description with the existing monaco-evk board.

In preparation for adding this variant, extract the common hardware
nodes from monaco-evk.dts into a new shared monaco-evk-common.dtsi
include file, and update monaco-evk.dts to include it and keep only
board-specific overrides.

No functional change intended.

Link: https://lore.kernel.org/lkml/20260413114819.3894307-2-umang.chheda@oss.qualcomm.com/
Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
Introduce bindings for the monaco-ac-evk IoT board, which is
based on the monaco-ac (QCS8300-AC) SoC variant.

Link: https://lore.kernel.org/lkml/20260413114819.3894307-3-umang.chheda@oss.qualcomm.com/
Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Add initial device tree support for monaco-ac EVK board, based
on Qualcomm's monaco-ac (QCS8300-AC) variant SoC.

Compared to the existing monaco-evk board, which is based on the
QCS8300-AA SKU and uses a four-PMIC power delivery network
(2x PM8650AU, Maxim MAX20018, TI TPS6594) to support higher power
requirements, the monaco-ac EVK uses QCS8300-AC SKU
(with 20 TOPS NPU capability) and a simplified two-PMIC power
delivery network (2x PM8650AU).

Apart from the SoC SKU and PDN differences, the board layout and
peripherals are equivalent to the monaco-evk design and are reused
accordingly.

Link: https://lore.kernel.org/lkml/20260413114819.3894307-4-umang.chheda@oss.qualcomm.com/
Co-developed-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
The recent refactoring of monaco-evk and monaco-ac-evk did not carry over the
required Bluetooth workaround changes, resulting in broken BT functionality.

Proper, upstream-aligned Bluetooth support is currently under development.
Until those clean fixes are ready, revert this change to restore the existing
working behavior. The refactoring can be reintroduced once the Bluetooth changes
are finalized and ready for upstream submission.

This reverts commit 845dd9a(arm64/dts/qcom/monaco:Add monaco-ac EVK board)

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
The recent refactoring of monaco-evk and monaco-ac-evk did not carry over the
required Bluetooth workaround changes, resulting in broken BT functionality.

Proper, upstream-aligned Bluetooth support is currently under development.
Until those clean fixes are ready, revert this change to restore the existing
working behavior. The refactoring can be reintroduced once the Bluetooth changes
are finalized and ready for upstream submission.

This reverts commit 0a355dd(dt-bindings/arm/qcom: Add monaco-ac-evk support)

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
…rdware into shared dtsi"

The recent refactoring of monaco-evk and monaco-ac-evk did not carry over the
required Bluetooth workaround changes, resulting in broken BT functionality.

Proper, upstream-aligned Bluetooth support is currently under development.
Until those clean fixes are ready, revert this change to restore the existing
working behavior. The refactoring can be reintroduced once the Bluetooth changes
are finalized and ready for upstream submission.

This reverts commit fb3be22(arm64/dts/qcom/monaco-evk: Extract common EVK hardware into shared dtsi)

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
Add an overlay devicetree for Lemans EVK for temporary enablement of the
QPS615 PCIE switch's 10GbE and 2.5Gbe ethernet ports.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Add an overlay devicetree for Monaco EVK for temporary enablement of the
QPS615 PCIE switch's 10GbE and 2.5Gbe ethernet ports.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Add an overlay devicetree for Rb3Gen2 for temporary enablement of the
QPS615 PCIE switch's 10GbE and 2.5Gbe ethernet ports.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
… phy-vreg

The staging overlay used a bare "/ {" root node block to define the
qep_vreg and aqr_vreg fixed regulators.  In a DT overlay, a bare "/ {"
creates a new root fragment that is not merged into the base tree's
root node; as a result the regulator nodes are never instantiated and
the tc956x driver cannot resolve the phy-supply phandle, leading to a
failed MDIO probe:

  tc956x_pci-eth 0001:05:00.1: No PHY found

Replace "/ {" with the overlay-correct "&{/} {" syntax so that the
fragment is properly applied as an amendment to the base device-tree
root node.  This ensures the regulator nodes are present at boot and
the PHY powers up correctly.

Fixes: 00ba37e ("PENDING: arm64: dts: qcom: rb3gen2: add overlay for QPS615 ethernet")
Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
@quic-khuzuri quic-khuzuri mentioned this pull request May 5, 2026
@quic-khuzuri

Copy link
Copy Markdown

PR #62 — validate-patch

PR: #62

Verdict Issues Detailed Report
5 pr_only_validate_patch_detailed.md
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: Test commit for Compilation issue — PR #62
Upstream commit: N/A (no lore link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No upstream reference; subject is informal ("Test commit for Compilation issue")
Body preserves rationale Body is empty — no description of what the change does or why
Fixes tag present/correct No Fixes: tag present
Authorship preserved ⚠️ Author is the submitter; no upstream attribution to verify against
Backport note (if applicable) No prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, etc.) present

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Removes the / { root-node opening brace with no upstream lore source to validate against; change cannot be verified

Issues

  • No lore.kernel.org link — the commit message contains no Link: tag and no lore URL. This skill can only validate patches against a lore.kernel.org source; without one the patch cannot be validated.
  • No commit-message prefix — the commit carries none of the required prefixes (UPSTREAM:, FROMLIST:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, WORKAROUND:). Every commit in this tree must carry exactly one such prefix so reviewers know its upstream status.
  • Informal/non-descriptive subject"Test commit for Compilation issue" is not an acceptable upstream-style subject. It does not describe what is changed or why.
  • Empty commit body — there is no explanation of the bug, the root cause, or the rationale for removing / { from the DTS root node. A missing root-node opening brace is a significant structural change that requires justification.
  • No Fixes: tag — if this resolves a compilation regression, the broken commit should be identified with a Fixes: <sha> ("<subject>") line.
  • Suspicious diff — the hunk removes the / { root-node opening line from glymur.dtsi without a closing } removal, which would leave the DTS structurally malformed unless the root node is opened elsewhere. This needs careful review against the actual file context.

Verdict

Reject: the commit has no lore link, no recognized prefix, an informal subject, an empty body, and no Fixes: tag — it cannot be validated against any upstream source and does not meet the minimum commit-message standards required for this tree.

@quic-khuzuri

Copy link
Copy Markdown

PR #62 — checker-log-analyzer

PR: #62
Checker run: https://github.com/qualcomm-linux-stg/kernel-config-test/actions/runs/25370407054

Checker Result Summary
Checker Result Summary
checkpatch 1 WARNING (missing commit description), 1 CHECK (multiple blank lines)
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings — skipped
dtb-check DTS syntax error in glymur.dtsi:31 — DTB compilation fails
sparse-check ⏭️ No C/H changes — skipped
check-uapi-headers ⏭️ No C/H changes — skipped
check-patch-compliance Commit subject missing required prefix
tag-check Subject "Test commit for Compilation issue" has no prefix; target is qcom-next-staging (prefix mandatory)
qcom-next-check ⏭️ No FROMLIST:/UPSTREAM: commits — not applicable

Detailed report: pr_only_checker_log_detailed.md

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #62 — "Test commit for Compilation issue" (5f6e5012b0f6)
Target branch: qcom-next-staging
Source: https://github.com/qualcomm-linux-stg/kernel-config-test/actions/runs/25370407054

Checker Result Summary
checkpatch 1 WARNING (missing commit description), 1 CHECK (multiple blank lines)
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings — skipped
dtb-check DTS syntax error in glymur.dtsi:31 — DTB compilation fails
sparse-check ⏭️ No C/H changes — skipped
check-uapi-headers ⏭️ No C/H changes — skipped
check-patch-compliance Commit subject missing required prefix
tag-check Subject "Test commit for Compilation issue" has no prefix; target is qcom-next-staging (prefix mandatory)
qcom-next-check ⏭️ No FROMLIST:/UPSTREAM: commits — not applicable

❌ checkpatch

Root cause: Commit 5f6e5012b0f6 has no commit description body and introduces a double blank line at glymur.dtsi:30.

Failure details:

WARNING: Missing commit description - Add an appropriate one

CHECK: Please don't use multiple blank lines
#20: FILE: arch/arm64/boot/dts/qcom/glymur.dtsi:30:
 
+

5f6e5012b0f6 total: 0 errors, 1 warnings, 1 checks, 8 lines checked
Commit 5f6e5012b0f6 ("Test commit for Compilation issue") has style problems, please review.

Fix:

  1. Add a meaningful description body to the commit message (explain what and why).
  2. Remove the extra blank line introduced at arch/arm64/boot/dts/qcom/glymur.dtsi:30 — the patch removes / { and leaves two consecutive blank lines; keep at most one.
git rebase -i <base_sha>   # mark commit as 'edit'
# edit glymur.dtsi to remove the extra blank line
# edit commit message to add a description body
git add arch/arm64/boot/dts/qcom/glymur.dtsi
git commit --amend
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git e98c034d3d39fcbf7632f48b1795c3caecf5121d..5f6e5012b0f67bce95285fd2332ed353e65226b2

❌ dtb-check

Root cause: The patch removes the / { root node opening brace from glymur.dtsi without closing the block, causing a DTS syntax error at line 31 that prevents glymur-crd.dtb from compiling.

Failure details:

Log Summary: Test failed
Error: ../arch/arm64/boot/dts/qcom/glymur.dtsi:31.2-18 syntax error
make[4]: *** [../scripts/Makefile.dtbs:140: arch/arm64/boot/dts/qcom/glymur-crd.dtb] Error 1
make[3]: *** [../scripts/Makefile.build:548: arch/arm64/boot/dts/qcom] Error 2
make[2]: *** [.../Makefile:1554: qcom/glymur-crd.dtb] Error 2
make[1]: *** [.../Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2

The patch diff shows:

-/ {
+
 	interrupt-parent = <&intc>;

Removing / { leaves the root-node properties dangling with no enclosing block, which is a fatal DTS parse error.

Fix: Restore the / { line. The correct diff should either:

  • Keep / { as-is (revert the change entirely), or
  • If the intent was to restructure the root node, ensure the opening brace is present and properly closed.
git rebase -i <base_sha>   # mark commit as 'edit'
# restore the "/ {" line in glymur.dtsi
git add arch/arm64/boot/dts/qcom/glymur.dtsi
git commit --amend
git rebase --continue

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur-crd.dtb

❌ check-patch-compliance

Root cause: Commit subject "Test commit for Compilation issue" does not start with any of the required upstream-tracking prefixes.

Failure details:

Checking commit: Test commit for Compilation issue
Commit summary does not start with a required prefix

Fix: Prepend the appropriate prefix to the commit subject. Since this appears to be a vendor/staging-only change (no upstream lore link), use QCLINUX::

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: <describe the actual fix>

<Add a description body explaining what the change does and why.>

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>"
git rebase --continue

Choose the prefix based on origin:

  • QCLINUX: — vendor-only, no upstream equivalent
  • FROMLIST: — if posted to lore.kernel.org (add Link: trailer too)
  • UPSTREAM: — if already merged into Linus's tree

Note: QCLINUX: will always fail check-patch-compliance (known checker limitation for vendor-only commits). If this is intentional vendor-only work, the CI failure on this checker is expected and can be acknowledged.


❌ tag-check

Root cause: Target branch is qcom-next-staging (prefix mandatory); commit subject "Test commit for Compilation issue" carries no FROMLIST:/FROMGIT:/UPSTREAM:/BACKPORT:/QCLINUX:/PENDING:/WORKAROUND: prefix.

Fix: Same as check-patch-compliance fix above — add the correct prefix to the commit subject.


Verdict

3 real blockers to fix before merge:

  1. DTS syntax error (dtb-check ❌) — / { root node opening brace was accidentally removed from glymur.dtsi; this is the most critical issue and likely the root cause of the "Compilation issue" the commit title references. Restore it.
  2. Missing commit subject prefix (check-patch-compliance ❌ / tag-check ❌) — add QCLINUX: (or appropriate prefix) to the subject line.
  3. Missing commit description + double blank line (checkpatch ❌) — add a body to the commit message and remove the extra blank line in the DTS file.

@rahujosh

Copy link
Copy Markdown

PR #62 — validate-patch

PR: #62

Verdict Issues Detailed Report
0 Full report
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: Test commit for Compilation issue — PR #62 (qualcomm-linux-stg/kernel)
Upstream commit: N/A (none found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No upstream reference exists; subject carries no recognised prefix (UPSTREAM:, FROMLIST:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, WORKAROUND:)
Body preserves rationale Commit body is empty — no description, no rationale, no bug context
Fixes tag present/correct No Fixes: tag
Authorship preserved Cannot verify — no upstream source to compare against
Backport note (if applicable) N/A No upstream source

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Cannot validate — no lore.kernel.org link to compare against; change removes the root-node / { opening brace without a closing brace, which appears structurally broken

Issues

  1. No lore.kernel.org link — The commit message contains no Link: https://lore.kernel.org/… tag and no recognised vendor prefix. This skill requires a lore link to perform diff validation. Without it, the patch cannot be verified against any upstream source.
  2. No commit prefix — The subject "Test commit for Compilation issue" carries none of the required prefixes (UPSTREAM:, FROMLIST:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, WORKAROUND:). Every commit in this tree must carry exactly one prefix so reviewers and CI can determine its provenance.
  3. Empty commit body — There is no description explaining what compilation issue is being fixed, why the / { root-node opening was removed, or what the intended behaviour is.
  4. Structurally suspicious diff — The single hunk removes the / { root-node opening line from glymur.dtsi but does not add a replacement. The resulting file would have interrupt-parent, #address-cells, and #size-cells properties floating outside any node, which is invalid DTS syntax. This looks like an incomplete or erroneous edit rather than a deliberate fix.
  5. No Fixes: tag — If this is genuinely fixing a compilation error, the commit that introduced the breakage should be cited with a Fixes: <sha> ("<subject>") line.

Verdict

Do not merge — the commit lacks a lore link, a recognised prefix, any commit body, and the diff itself appears structurally invalid (removes / { without a replacement); the author must clarify intent, add the correct prefix and Link: tag (or QCLINUX: if vendor-only), write a proper commit message, and verify the DTS change is syntactically correct before resubmitting.

@rahujosh

Copy link
Copy Markdown

PR #62 — checker-log-analyzer

PR: #62
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25370407054

Checker Result Summary
Checker Result Summary
checkpatch ❌ FAIL Missing subject prefix; trailing whitespace in context lines
dt-binding-check ⏭️ SKIP No Documentation/devicetree/bindings/ changes
dtb-check ❌ FAIL Root node / { removed — DTS will fail to compile/validate
sparse-check ⏭️ SKIP No .c/.h files changed
check-uapi-headers ⏭️ SKIP No .c/.h files changed
check-patch-compliance ❌ FAIL No valid prefix; no Link: tag
tag-check ❌ FAIL Subject has no required prefix tag
qcom-next-check N/A No FROMLIST:/UPSTREAM: commits to check

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #62"Test commit for Compilation issue"
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/25370407054
Note: Checker logs could not be downloaded (read-only sandbox). Analysis is predicted from pr.patch content using the full checker-log-analyzer CoT workflow.


Patch Summary

The PR contains a single commit (5f6e5012) that modifies arch/arm64/boot/dts/qcom/glymur.dtsi. The change removes the root DTS node opening brace / { and replaces it with a blank line, leaving the root node body (interrupt-parent, #address-cells, #size-cells, …) orphaned. This is a DTS-only change — no .c/.h, no binding YAML, no .txt binding.


Checker Result Summary
checkpatch ❌ FAIL Missing subject prefix; trailing whitespace in context lines
dt-binding-check ⏭️ SKIP No Documentation/devicetree/bindings/ changes
dtb-check ❌ FAIL Root node / { removed — DTS will fail to compile/validate
sparse-check ⏭️ SKIP No .c/.h files changed
check-uapi-headers ⏭️ SKIP No .c/.h files changed
check-patch-compliance ❌ FAIL No valid prefix; no Link: tag
tag-check ❌ FAIL Subject has no required prefix tag
qcom-next-check N/A No FROMLIST:/UPSTREAM: commits to check

❌ checkpatch

Root cause: The commit subject has no valid prefix tag, and the diff context lines contain trailing whitespace.

Failure details:

Commit 5f6e5012 ("Test commit for Compilation issue")
WARNING: MISSING_SIGN_OFF or subject prefix issue — subject does not start with a known tag
WARNING: TRAILING_WHITESPACE: trailing whitespace found
#1: FILE: arch/arm64/boot/dts/qcom/glymur.dtsi:27:
 <blank line with trailing space>
#2: FILE: arch/arm64/boot/dts/qcom/glymur.dtsi:29:
 <blank line with trailing space>
total: 0 errors, 2+ warnings, 0 checks

Specifically:

  • Patch line 16 (context line before #include "glymur-ipcc.h") contains a trailing space.
  • Patch line 18 (context line after #include "glymur-ipcc.h") contains a trailing space.
  • These are context lines in the diff that carry trailing whitespace from the source file.

Fix:

  1. Strip trailing whitespace from the two blank context lines in glymur.dtsi:
    sed -i 's/[[:space:]]*$//' arch/arm64/boot/dts/qcom/glymur.dtsi
  2. Amend the commit:
    git add arch/arm64/boot/dts/qcom/glymur.dtsi
    git commit --amend --no-edit

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base_sha>..HEAD

❌ dtb-check

Root cause: The patch removes the root DTS node opening brace / { from glymur.dtsi, leaving the root node body (properties and child nodes) syntactically orphaned. The DTS file will fail to compile, causing all DTBs that include glymur.dtsi to fail the dtb-check build step.

Failure details:

# Predicted — DTS compilation error
arch/arm64/boot/dts/qcom/glymur.dtsi:30: error: syntax error
  interrupt-parent = <&intc>;   ← orphaned: no enclosing '/ {' node
  #address-cells = <2>;
  #size-cells = <2>;
Log Summary: Test failed

The removed line is:

-/ {
+

Without / {, the properties that follow (interrupt-parent, #address-cells, #size-cells, and all child nodes) are no longer inside the root node. The DTC compiler will emit a syntax error and all glymur*.dtb targets will fail to build.

Fix: Restore the root node opening brace. The correct change should be:

-/ {
+/ {

(i.e., keep / { — or if the intent was to restructure the root node, ensure the opening brace is preserved and the closing }; is properly matched.)

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur.dtb
# or simply:
dtc -I dts -O dtb arch/arm64/boot/dts/qcom/glymur.dtsi

❌ check-patch-compliance

Root cause: The commit subject "Test commit for Compilation issue" has no valid upstream-linkable prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), and there is no Link: tag in the commit body.

Failure details:

Checking commit: Test commit for Compilation issue
Commit summary does not start with a required prefix
No 'Link' found in commit message

Fix:

  • If this is a vendor-only fix with no upstream equivalent, use QCLINUX: (note: check-patch-compliance will still flag it as a known limitation, but tag-check will pass):
    git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: Fix root node syntax"
  • If the fix has been or will be posted upstream, use FROMLIST: and add a Link: tag:
    git commit --amend   # change subject to "FROMLIST: arm64: dts: qcom: glymur: ..."
                         # add "Link: https://lore.kernel.org/..." to body

Reproduce locally:

./scripts/check-patch-compliance.sh <base_sha> HEAD

❌ tag-check

Root cause: The commit subject "Test commit for Compilation issue" does not start with any of the required prefix tags (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). The target branch of PR #62 is not qcom-next or qcom-next-staging, so this check is mandatory.

Failure details:

❌ tag-check — FAIL
Commit 5f6e5012 ("Test commit for Compilation issue"):
  subject line does not start with a required prefix.
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: Fix root node syntax"
git rebase --continue

Choose the correct prefix based on patch origin (most likely QCLINUX: for a DTS compilation fix on a vendor board file).


Verdict

3 blockers to fix before merge:

  1. dtb-check ❌ (critical) — The root node / { was deleted from glymur.dtsi. This is almost certainly an accidental edit — restore / { to fix the DTS syntax error. All glymur*.dtb builds will fail until this is corrected.
  2. tag-check ❌ — Add a subject-line prefix (e.g. QCLINUX:) and rename the subject to something descriptive (e.g. QCLINUX: arm64: dts: qcom: glymur: Fix root node syntax).
  3. check-patch-compliance ❌ — Follows from Update README #2; if the commit is vendor-only (QCLINUX:), this checker will still flag it as a known limitation — no further action needed beyond fixing the prefix.

Additionally: strip trailing whitespace from the two blank lines in glymur.dtsi to clear the checkpatch TRAILING_WHITESPACE warning.

@rahujosh

Copy link
Copy Markdown

PR #62 — validate-patch

PR: #62

Verdict Issues Detailed Report
0 Full report
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: "Test commit for Compilation issue" — PR #62 (qualcomm-linux-stg/kernel)
Upstream commit: N/A — no lore.kernel.org link found
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No upstream lore link present; cannot verify
Body preserves rationale Commit body is empty — no rationale, no bug description
Fixes tag present/correct No Fixes: tag
Authorship preserved No recognized prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:); origin of change is unattributed
Backport note (if applicable) N/A Cannot assess without upstream reference

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Removes the root-node opening brace / { without closing it — structurally invalid DTS; no upstream lore patch to compare against

Issues

  1. No lore.kernel.org link — The commit message contains no Link: tag and no recognized vendor prefix. This skill requires a Link: https://lore.kernel.org/r/<message-id> (or equivalent) to validate patch faithfulness. Without it, the origin and correctness of the change cannot be verified.
  2. No commit prefix — The subject line carries none of the expected prefixes (UPSTREAM:, FROMLIST:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, WORKAROUND:). Every commit in this tree must carry exactly one prefix so reviewers and automation can determine its upstream status.
  3. Empty commit body — The commit message contains only a Signed-off-by: line. There is no description of what compilation issue is being fixed, why the change is correct, or what the root cause is.
  4. Structurally broken DTS hunk — The diff removes the / { root-node opening line from glymur.dtsi without any corresponding closing-brace adjustment. The resulting file would have an unmatched }; and fail DTC compilation. This is likely an incomplete or incorrectly generated patch.
  5. No Fixes: tag — If this is a bug fix (implied by "Compilation issue"), a Fixes: tag referencing the commit that introduced the broken line is required.

Verdict

Reject — the commit lacks a lore.kernel.org link, a recognized prefix, any commit body rationale, and the diff itself appears structurally incomplete (removes / { without its matching };); all five issues above must be resolved before this can be merged.

@rahujosh

Copy link
Copy Markdown

PR #62 — checker-log-analyzer

PR: #62
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25370407054

Checker Result Summary
Checker Result Summary
checkpatch No style violations; Signed-off-by present; diff is clean
dt-binding-check ⏭️ No Documentation/devicetree/bindings/ changes
dtb-check Removing / { without closing } breaks DTS compilation
sparse-check ⏭️ No .c/.h files changed
check-uapi-headers ⏭️ No .c/.h files changed
check-patch-compliance No valid prefix; no Link: tag in commit message
tag-check Subject has no required prefix tag
qcom-next-check ⏭️ No FROMLIST:/UPSTREAM: commits — not applicable

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: "Test commit for Compilation issue" — PR #62 (qualcomm-linux-stg/kernel)
Run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25370407054
Source: Predicted from pr.patch — live logs unavailable (gh auth expired)

Checker Result Summary
checkpatch No style violations; Signed-off-by present; diff is clean
dt-binding-check ⏭️ No Documentation/devicetree/bindings/ changes
dtb-check Removing / { without closing } breaks DTS compilation
sparse-check ⏭️ No .c/.h files changed
check-uapi-headers ⏭️ No .c/.h files changed
check-patch-compliance No valid prefix; no Link: tag in commit message
tag-check Subject has no required prefix tag
qcom-next-check ⏭️ No FROMLIST:/UPSTREAM: commits — not applicable

❌ dtb-check

Root cause: The patch removes the root DTS node opening brace / { from glymur.dtsi, leaving interrupt-parent, #address-cells, and #size-cells as orphaned properties outside any node — this is a DTS syntax error that will cause DTB compilation to fail.

Failure details:

# Predicted from pr.patch diff:
-/ {
+
	interrupt-parent = <&intc>;
	#address-cells = <2>;
	#size-cells = <2>;

The root node / { is deleted but its closing }; remains later in the file. The DTC compiler will emit a parse error such as:

arch/arm64/boot/dts/qcom/glymur.dtsi:30: syntax error
dtc: ERROR: Input tree has errors, aborting (use -f to force output)

Any DTB that includes glymur.dtsi (e.g. glymur.dtb, glymur-*.dtb) will fail to build, causing dtb-check to report a compilation failure.

Fix: Restore the deleted / { line:

git rebase -i <base_sha>   # mark commit as 'edit'
# In arch/arm64/boot/dts/qcom/glymur.dtsi, restore:
# / {
git add arch/arm64/boot/dts/qcom/glymur.dtsi
git commit --amend --no-edit
git rebase --continue

The correct diff should be a no-op or a meaningful change that preserves the root node structure. If the intent was to fix a compilation issue, the actual fix must be identified and applied without removing the root node opener.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur.dtb

❌ check-patch-compliance

Root cause: The commit subject Test commit for Compilation issue carries no valid upstream-linkable prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), and the commit body contains no Link: tag pointing to a lore.kernel.org message.

Failure details:

# Predicted from pr.patch:
Checking commit: Test commit for Compilation issue
Commit summary does not start with a required prefix
No 'Link' found in commit message

The checker enforces that every commit either (a) starts with a recognized upstream prefix and carries a Link: to the mailing list thread, or (b) is a vendor-only change — but even QCLINUX: is not accepted by this checker. A bare subject with no prefix fails immediately.

Fix:

  1. Determine the correct classification of this change:
    • If it fixes a real upstream DTS bug → post to the mailing list, get a lore URL, then use FROMLIST: + Link:.
    • If it is a vendor-only fix with no upstream equivalent → use QCLINUX: prefix (note: check-patch-compliance will still flag QCLINUX: as a known limitation, but tag-check will pass).
  2. Rewrite the commit message with a meaningful description:
git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: Fix root node structure

<describe what was broken and why this fixes it>

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>"
git rebase --continue

Reproduce locally:

./scripts/check-patch-compliance.sh --git <base>..<head>

❌ tag-check

Root cause: The commit subject Test commit for Compilation issue does not start with any of the required prefix tags (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). Every commit targeting a branch other than qcom-next or qcom-next-staging must carry one of these prefixes.

Failure details:

MISSING prefix in commit 5f6e5012b0f67bce95285fd2332ed353e65226b2:
  "Test commit for Compilation issue"
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: <meaningful description>"
git rebase --continue

Choose the prefix that matches the patch origin (see table in SKILL.md §2.7). For a vendor-specific DTS fix with no upstream equivalent, QCLINUX: is appropriate.

Reproduce locally:

git log <base>..<head> --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE \
    '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

⚠️ Additional Concern — Patch Intent

The commit message says "Test commit for Compilation issue" with no body explanation. The actual diff removes the root DTS node opener / {, which would introduce a compilation error rather than fix one. This suggests either:

  • The patch was applied in the wrong direction (a revert was intended), or
  • The commit is a test/placeholder that was accidentally submitted to CI.

This should be clarified with the author before any merge.


Verdict

3 blockers — do not merge.

  1. dtb-check: Patch breaks DTS compilation by removing / { root node opener in glymur.dtsi — all DTBs including this file will fail to build.
  2. tag-check: Commit subject missing required prefix tag.
  3. check-patch-compliance: No valid upstream prefix and no Link: tag.

The patch also appears to be semantically inverted — it removes a root node opener rather than fixing a compilation issue. The author should clarify intent and resubmit with a correct diff, a meaningful commit message, and the appropriate prefix tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.