Skip to content

FROMLIST: arm64: dts: qcom: glymur: Add memory-region for audio PD#1453

Open
Vinayak (quic-vkatoch) wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
quic-vkatoch:glymur-audio
Open

FROMLIST: arm64: dts: qcom: glymur: Add memory-region for audio PD#1453
Vinayak (quic-vkatoch) wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
quic-vkatoch:glymur-audio

Conversation

@quic-vkatoch

@quic-vkatoch Vinayak (quic-vkatoch) commented Jul 2, 2026

Copy link
Copy Markdown

Patch: Reserve memory region for audio PD dynamic loading and remote heap requirements. Add the required VMID list for memory ownership transfers.

Link: https://lore.kernel.org/all/20260701-glymur-audio-v1-1-2c3862d95a09@oss.qualcomm.com/

CRs-Fixed: 4593331

Reserve memory region for audio PD dynamic loading and remote heap
requirements. Add the required VMID list for memory ownership
transfers.

Link: https://lore.kernel.org/all/20260701-glymur-audio-v1-1-2c3862d95a09@oss.qualcomm.com/
Reviewed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, aiquny, Tingwei Zhang (quic-tingweiz) and yijiyang and removed request for a team July 2, 2026 06:16
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1453

PR: #1453
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28569668158

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur.dtsi No Baseline branch has diverged; concurrent changes in overlapping regions
2 Merge conflict (add/add) Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing integration conflict between baseline and topic branches
3 Interactive merge tool invocation N/A No Automerge attempted to use vimdiff in non-interactive CI environment

Verdict

This is not a compilation failure. The build failed during branch integration due to merge conflicts between the PR branch and the baseline. The PR changes are syntactically valid but conflict with concurrent modifications in the baseline branch. All 100+ conflicts are pre-existing integration issues, not introduced by the PR code itself.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1453

PR: #1453
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28569668158

Build Failure Type: Integration Merge Conflict (Not Compilation Error)

The build failed during the integration merge phase, not during compilation. The CI workflow attempts to merge multiple topic branches together, and this PR's changes to arch/arm64/boot/dts/qcom/glymur.dtsi conflict with changes from other topic branches being integrated.

# Conflict Type File PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/glymur.dtsi Yes PR adds memory-region and includes to glymur.dtsi, which conflicts with other changes in topic/tech/all/dt/glymur branch
2 Merge conflict sound/soc/qcom/qdsp6/audioreach.c No Pre-existing conflict between other topic branches
3 Merge conflict sound/soc/qcom/qdsp6/q6apm-dai.c No Pre-existing conflict between other topic branches
4 Merge conflict sound/soc/qcom/qdsp6/q6apm.c No Pre-existing conflict between other topic branches
5 Merge conflict Multiple DT bindings & drivers No Pre-existing conflicts between other topic branches (20+ files)

Verdict

1 of 24+ merge conflicts is introduced by this PR; the remaining conflicts are pre-existing integration issues between other topic branches. This is not a compilation error — the code would likely compile successfully if the merge conflicts were resolved.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1453 — validate-patch

PR: #1453

Verdict Issues Detailed Report
N/A 9 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260701-glymur-audio-v1-1-2c3862d95a09@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network restricted; manual fetch required
  3. Upstream patch status: Cannot determine — network restricted; check lore thread manually for acceptance signals
  4. PR present in qcom-next: No — not found by subject or diff fingerprint search
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1453 - FROMLIST: arm64: dts: qcom: glymur: Add memory-region for audio PD
Upstream commit: https://lore.kernel.org/all/20260701-glymur-audio-v1-1-2c3862d95a09@oss.qualcomm.com/
Verdict: ⏭️ SKIPPED (network restricted - cannot fetch upstream for comparison)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network restricted
Body preserves rationale Clear description of memory region purpose
Fixes tag present/correct N/A Not a fix - new feature addition
Authorship preserved ⏭️ FROMLIST: submitter in From: is acceptable; cannot verify lore author without network access
Backport note (if applicable) N/A FROMLIST prefix used correctly

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi:11 Adds dt-bindings/firmware/qcom,scm.h include
arch/arm64/boot/dts/qcom/glymur.dtsi:664 Adds adsp_rpc_remote_heap_mem memory region
arch/arm64/boot/dts/qcom/glymur.dtsi:3854 Adds memory-region and qcom,vmids properties to fastrpc node

Commit Message Structure Analysis

Prefix: FROMLIST: correctly used for patches posted to mailing list but not yet merged
Link tag: Present and properly formatted
Reviewed-by: Present (Ekansh Gupta)
Signed-off-by: Present (Vinayak Katoch - matches From:)
Author: Vinayak Katoch vinayak.katoch@oss.qualcomm.com

Note on FROMLIST authorship: For FROMLIST: commits, the submitter (who cherry-picked and prefixed the commit) legitimately appears in From: and adds their own Signed-off-by:. Without network access to fetch the lore patch, I cannot verify whether the original lore author's Signed-off-by: is present if the submitter differs from the lore author. However, the current structure shows Vinayak Katoch as both author and signer, which is consistent.

Upstream Patch Status

⏭️ Cannot determine - Network access restricted; unable to fetch lore thread or check mainline/stable trees for merge status.

Expected workflow: The patch should be checked against:

  1. Lore thread for acceptance signals (applied/queued/Reviewed-by/Acked-by from maintainer)
  2. torvalds/linux mainline for merge commit
  3. Maintainer trees (qcom-next, linux-next) for queued status

qcom-next Presence

Commit Status
arm64: dts: qcom: glymur: Add memory-region for audio PD ⚠️ Not in qcom-next

Search performed:

  • Subject search: No match found
  • Diff fingerprint search: No match found (fingerprint: 3761cdd4e2ec562a54d8bf00c94fb549)
  • Recent commits in glymur.dtsi checked: Last 20 commits examined, none match

Issues

Network Restriction Impact:

  • ⚠️ Cannot fetch upstream lore patch for diff comparison
  • ⚠️ Cannot verify commit message matches lore posting
  • ⚠️ Cannot check upstream acceptance status (ACKed/NACKed/Pending)
  • ⚠️ Cannot verify original lore author's Signed-off-by is preserved (if submitter differs from author)

Structural Observations (based on PR patch only):

  • ✅ Commit message structure follows kernel conventions
  • ✅ Link tag properly formatted and placed before Signed-off-by
  • ✅ Diff adds coherent functionality (memory region + VMID list for audio PD)
  • ✅ Changes are localized to a single DTS file
  • ✅ No obvious semantic issues in the diff content

Verdict

Cannot complete full validation due to network restrictions preventing upstream lore patch fetch and status verification.

What can be verified (PR patch structure only):

  • ✅ Commit message format is correct
  • ✅ FROMLIST prefix appropriately used
  • ✅ Link tag present and properly formatted
  • ✅ Diff content is coherent and focused
  • ⚠️ Patch not yet present in qcom-next

What requires manual verification:

  1. Fetch the lore patch manually and compare diff content for faithfulness
  2. Check lore thread for community acceptance status (ACKed/NACKed/Pending)
  3. Verify original lore author's Signed-off-by is present if submitter differs from lore author
  4. Confirm no semantic changes were introduced during cherry-pick

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260701-glymur-audio-v1-1-2c3862d95a09@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network restricted; manual fetch required
  3. Upstream patch status: Cannot determine — network restricted; check lore thread manually for acceptance signals
  4. PR present in qcom-next: No — not found by subject or diff fingerprint search

@qlijarvis

Copy link
Copy Markdown

PR #1453 — checker-log-analyzer

PR: #1453
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28569668250

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check Subject has valid FROMLIST: prefix
qcom-next-check N/A Target branch is qcom-next - prefix not mandatory

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1453 - FROMLIST: arm64: dts: qcom: glymur: Add memory-region for audio PD
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28569668250

Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check Subject has valid FROMLIST: prefix
qcom-next-check N/A Target branch is qcom-next - prefix not mandatory

⚠️ CI Infrastructure Failure

Root cause: All checker jobs failed during the merge phase with fatal: refusing to merge unrelated histories before any actual checks could run.

Failure details:

2026-07-02T06:33:35.2898911Z  ** Merging topic branch: topic/tech/all/dt/glymur
2026-07-02T06:33:53.3963972Z fatal: refusing to merge unrelated histories
2026-07-02T06:33:53.5017151Z Merge failed, manual merge
...
2026-07-02T06:33:54.5007477Z Merging pr-1453 (no-commit)...
2026-07-02T06:34:13.9220399Z fatal: refusing to merge unrelated histories
2026-07-02T06:34:14.0289280Z Merge failed or conflicts detected. Aborting merge.
2026-07-02T06:34:14.0326970Z ##[error]Process completed with exit code 3.

The CI workflow attempted to:

  1. Merge topic branch topic/tech/all/dt/glymur into integration branch → failed with unrelated histories
  2. Merge PR FROMLIST: arm64: dts: qcom: glymur: Add memory-region for audio PD #1453 into integration branch → failed with unrelated histories

This error indicates the topic branch and/or PR branch have no common ancestor with the baseline branch (qcom-next at commit 19b282f417584cfe14ce6a262122c51553d026ec), which is a CI configuration or branch setup issue, not a patch defect.

Fix: Re-trigger the CI workflow. If the issue persists, verify that:

  • The topic branch topic/tech/all/dt/glymur is properly based on qcom-next
  • The PR branch is properly based on the target branch
  • The CI merge strategy allows --allow-unrelated-histories if needed

Note: No patch changes are required. The patch itself appears well-formed:

  • ✅ Has valid FROMLIST: prefix
  • ✅ Includes upstream Link: to lore.kernel.org
  • ✅ Has proper Signed-off-by: and Reviewed-by: trailers
  • ✅ DTS-only change (adds memory-region for audio PD)

✅ Manual Patch Review

Since the automated checkers could not run, I performed a manual review of the patch:

Commit message:

  • ✅ Subject has FROMLIST: prefix (valid for target branch qcom-next)
  • ✅ Includes upstream link: https://lore.kernel.org/all/20260701-glymur-audio-v1-1-2c3862d95a09@oss.qualcomm.com/
  • ✅ Has Signed-off-by: trailer
  • ✅ Has Reviewed-by: trailer
  • ✅ Commit body explains the change clearly

Code changes:

  • ✅ Adds #include <dt-bindings/firmware/qcom,scm.h> for VMID constants
  • ✅ Adds reserved memory region adsp_rpc_remote_heap_mem with proper DT properties
  • ✅ References the memory region in fastrpc node with memory-region property
  • ✅ Adds qcom,vmids property with QCOM_SCM_VMID_LPASS and QCOM_SCM_VMID_ADSP_HEAP
  • ✅ No obvious style issues (proper indentation, no trailing whitespace visible)

Potential concerns:

  • The patch modifies glymur.dtsi which is a SoC-level file - ensure this memory region is appropriate for all boards using this SoC, or consider moving to board-level DTS if board-specific

Verdict

CI infrastructure failure - no patch defects detected. Re-trigger the CI workflow. The patch itself appears ready for merge once CI completes successfully. No code changes required.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/dt/glymur'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/dt/glymur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants