Add ventuno-q support#16
Conversation
f288442 to
b836a46
Compare
b836a46 to
393859b
Compare
|
Depends on #19. |
393859b to
bfd6068
Compare
bfd6068 to
47bb54b
Compare
The merge-base changed after approval.
47bb54b to
e73c46c
Compare
| " | ||
|
|
||
| MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \ | ||
| packagegroup-ventuno-q-firmware \ |
There was a problem hiding this comment.
This also needs to list the kernel modules needed for booting, like the ANX, fan controller and others
3e6ed80 to
ca09a43
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 5 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
ca09a43 to
f2f7231
Compare
95f410b to
1840bc7
Compare
|
Temporarily including #43 to unblock the CI. |
bb7293a to
0a0f66d
Compare
|
Ricardo Salveti (@ricardosalveti) #132 Checks TL:DR
and then a few symlinks necessary to execute fastrpc_test utility |
0x1 (EmbeddedAndroid)
left a comment
There was a problem hiding this comment.
Couple of small issues to fix from some local testing.
|
|
||
| KERNEL_DEVICETREE ?= " \ | ||
| qcom/monaco-arduino-monza.dtb \ | ||
| " |
There was a problem hiding this comment.
I think we need
KERNEL_DTC_FLAGS = "-@"
The monza EDK2 firmware applies its SKU device-tree overlays at boot, which needs symbols in the base DTB and without it the FDT handed to the kernel is malformed and the EFI stub places /chosen/bootargs in the strings block, corrupting the kernel command line so the rootfs never mounts.
I was testing the SOTA config, so this might just be specific to that config.
There was a problem hiding this comment.
Hm, weird, there is nothing specific to ventuno here, and we have overlays for other targets as well, wonder if this is because we are just using the topic branch and not the complete qcom-next.
|
Another bigger issue for wifi I found, we are missing the correctly calibrated |
Can we use e.g. qca-swiss-army-knife to add the ID into the firmware at build time? |
Either that, or as a temporal measure install board file as |
0a0f66d to
e94baac
Compare
|
|
||
| KERNEL_DEVICETREE ?= " \ | ||
| qcom/monaco-arduino-monza.dtb \ | ||
| " |
There was a problem hiding this comment.
Need to append deferred_probe_timeout=30 to the cmdline args to get the GPU and NPU drivers to bind as is done in our Deb images: https://github.com/qualcomm-linux/qcom-deb-images/blob/d009737de97574b38c397e6d65b4b51d99610a64/debos-recipes/qualcomm-linux-debian-image.yaml#L78
There was a problem hiding this comment.
This is kind of hack, Loïc Minier (@lool) do we know why that was added in debian?
There was a problem hiding this comment.
The very first commit of qcom-deb-images had this already! Back then, I just accepted what people told me was required; this was already present in mkosi-qcom for instance:
https://github.com/qualcomm/mkosi-qcom/blob/main/mkosi.conf#L17
We had various chats on Slack about this, I'll ping you a link to one
There was a problem hiding this comment.
Maybe time to try to drop it or investigate if still needed?
f4d2335 to
26d36a0
Compare
|
I believe this is good enough for an initial build: |
| MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \ | ||
| packagegroup-ventuno-q-firmware \ | ||
| packagegroup-ventuno-q-hexagon-dsp-binaries \ | ||
| qairt-sdk-hexagon-v75 \ |
There was a problem hiding this comment.
Is the qairtsdk really essential?
There was a problem hiding this comment.
That's how we are adding them in our machines.
Based on https://github.com/qualcomm-linux/kernel-topics/tree/early/hwe/arduino. Temporary until all the required updates are available via qcom-next from meta-qcom. Also add a config fragment enabling the Monza board peripherals and drop the PENDING QPS615 patch from SRC_URI, as it doesn't apply on top of this tree. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add the CDT (Configuration Data Table) firmware for the Arduino VENTUNO Q (QCS8275 Monza), as available via CodeLinaro. The board reuses the generic QCS8300 boot firmware provided by meta-qcom, so deploy the CDT under the same 8300 subdirectory to follow the boot firmware path. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add packagegroup for ventuno-q, based on packagegroup-iq-8275-evk to start with. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
https://www.arduino.cc/product-ventuno-q The board is based on the QCS8275 (Monza) SoC, reusing the qcom-qcs8300 machine include, the linux-qcom-next kernel and the generic QCS8300 boot firmware from meta-qcom, with the board specific CDT provided by firmware-qcom-cdt-ventuno-q. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add kas machine fragment for Arduino VENTUNO Q. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add ventuno-q to the machine list. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
26d36a0 to
15c87aa
Compare
Add support for Arduino VENTUNO Q (monza).