Add RTSS mailbox FIT image support for iq-8275-evk and iq-9075-evk#2527
Add RTSS mailbox FIT image support for iq-8275-evk and iq-9075-evk#2527snegi-qti wants to merge 3 commits into
Conversation
The RTSS mailbox driver uses a dedicated DT overlay (rtss-mb.dtbo) that exists only in linux-qcom kernels. Add rtssmb variants of all existing qcs9075 and qcs8275 FIT DTB compatible entries, each extending the base compatible string with the rtss-mb DTB, so the bootloader can select the correct DTB bundle at boot for platforms with RTSS mailbox enabled. Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
The monaco-rtss-mb.dtbo overlay enables RTSS mailbox IPC support on the iq-8275-evk board. Add it to LINUX_QCOM_KERNEL_DEVICETREE to make it available for FIT image selection on this platform. Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
The lemans-rtss-mb.dtbo overlay enables RTSS mailbox IPC support on the iq-9075-evk board. Add it to LINUX_QCOM_KERNEL_DEVICETREE to make it available for FIT image selection on this platform. Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
|
Why is it an overlay rather than a part of the main DT? |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Describe why, not what. Why is this a separate overlay, why is it enabled via UEFI variable, etc.
|
There is no DT in linux-qcom-6.18 |
DTs are already merged : QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tree overlay · qualcomm-linux/kernel@f9e0… But the current meta-qcom linux-qcom recipe is pointing to older hash (https://github.com/qualcomm-linux/meta-qcom/blob/master/recipes-kernel/linux/linux-qcom_6.18.bb#L20), once it moves to latest, we will have the required changes. |
The RTSS Devicetree change is submitted as an overlay, as it cannot be added to intree kernel devicetree since the RTSS Devicetree and Driver are downstream, as of today. Hence, we have followed the existing precedent for "camx" which follows a similar approach of overlay + efivar activation to bring in this feature. Once this driver can be upstreamed, we shall move to intree approach. |
|
snegi-qti You are still describing that the driver is the out-of-tree module, etc. Describe, why do we want it in this way. What are the benefits. What is the usecase. Why the DTs are specified as an overlay rather than being merged in the base DTs in qcom-next, etc. CamX has an overlay DT, because the upstream kernel uses different bindings to desvribe the camera devices. If there are no conflicting upstream bindings, then the DT should be a part of the default DT. |
sargarram7 Could you please help answer the above queries for your RTSS driver ? |
|
qli-2.0 GA Critical Fix |
No, it's a new features, submitted pas the cut-off date. |
|
Apologies for the delayed and lengthy response and thank you for your valuable feedback. Why RTSS: Limitations of the Current Design: Ongoing Architectural Rework: Why Downstream Is Needed Now: Commitment: Request: Please consider this as common response to RTSS enablement PRs. |
This doesn't answer on the question, why is it necessary. In the end, sensor processing is handled by the SDSP or ADSP. Audio pipeline staging is also handled by the Linux / ASoC stack. How does it fit the IIO subsystem? What do you mean by control loops? How does it work? Does one submit a workload to the separate processor? Then you should be using remoteproc / rpmsg. Is it purely a synchronisation with the separate processor? How does it fit the programming model. Regarding the meta-qcom acceptance. Why is it a separate DT overlay? Granted that Linux already supports There should be no need for any DT overlays (nor toggling via the UEFI variables). If the hardware is there, it should be enabled. The driver can be a part of a separate DLKM (for now). |
Hi Dmitry Baryshkov (@lumag) , thanks for your guidance here. We understand the suggested direction for upstreaming the second qcom,ipcc instance. Since the existing RTSS use case is not upstreamed, we are concerned that the IPCC node itself may not be accepted in isolation. If our understanding is incorrect and a standalone qcom,ipcc provider node is expected to be acceptable upstream even without a current consumer, please let us know so that we can proceed accordingly. |
There is a user, it's called IPCC driver. |
Understood, thanks for clarifying. Our concern was around acceptance of a standalone IPCC DTS addition without any current upstream client DT nodes (like RTSS) referencing it. If the existing IPCC driver is sufficient justification for the second IPCC instance, that answers our question. |
The RTSS (Real Time Subsystem) mailbox driver uses a dedicated DT overlay (lemans-rtss-mb.dtbo/monaco-rtss-mb.dtbo). These changes wire up the overlay into the FIT image selection flow for platforms with RTSS mailbox IPC support enabled.
bundle at boot