Include modem firmware placeholder in packagegroup-qcm6490-idp#2561
Open
Viswanath Kraleti (vkraleti) wants to merge 4 commits into
Open
Include modem firmware placeholder in packagegroup-qcm6490-idp#2561Viswanath Kraleti (vkraleti) wants to merge 4 commits into
Viswanath Kraleti (vkraleti) wants to merge 4 commits into
Conversation
Viswanath Kraleti (vkraleti)
force-pushed
the
qcm6490-idp-mdm
branch
from
e33bac8 to
ef98138
Compare
Dmitry Baryshkov (lumag)
requested changes
Jun 25, 2026
| S = "${UNPACKDIR}" | ||
|
|
||
| require recipes-bsp/firmware/firmware-qcom.inc | ||
| require recipes-bsp/firmware/firmware-qcom-nhlos.inc |
Contributor
There was a problem hiding this comment.
Do we need to handle modem_pr files? I see them in the image for RB3 Gen2, but they are likely unsed there. My guess is that the IDP will use those files.
Contributor
There was a problem hiding this comment.
This is not addressed.
| do_compile:prepend() { | ||
| if [ -z "${NHLOS_URI}" ] ; then | ||
| bbwarn "${PN}: not packaging NHLOS firmware. Please provide HNLOS_URI" | ||
| bbdebug 1 "${PN}: not packaging NHLOS firmware. Please provide HNLOS_URI" |
Contributor
There was a problem hiding this comment.
Why? It is printed when this recipe is being compiled, which means that something has asked for this firmware.
Test Results 110 files 657 suites 8h 29m 40s ⏱️ For more details on these failures, see this check. Results for commit 7ee8ccc. ♻️ This comment has been updated with latest results. |
On QCM6490-IDP currently there is no straightforward way to deploy firmware
from a vendor-provided NON-HLOS.bin and users need to manage this outside
of the build system.
Add a firmware recipe that can extract and package firmware from a user
supplied NON-HLOS.bin, initially supporting only modem firmware. When no
image is provided, the recipe generates empty packages, allowing them to
remain in the packagegroups without requiring configuration changes by
users who do not use proprietary NON-HLOS.bin.
To specify the NON-HLOS.bin path, add the following to local.conf:
NHLOS_URI:pn-firmware-qcom-qcm6490-idp = "file:///PATH/NON-HLOS.bin"
Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
On Rb3Gen2 currently there is no straightforward way to deploy firmware
from a vendor-provided NON-HLOS.bin and users need to manage this outside
of the build system.
Add a firmware recipe that can extract and package firmware from a user
supplied NON-HLOS.bin, initially supporting only modem firmware. When no
image is provided, the recipe generates empty packages, allowing them to
remain in the packagegroups without requiring configuration changes
by users who do not use proprietary NON-HLOS.bin.
To specify the NON-HLOS.bin path, add the following to local.conf:
NHLOS_URI:pn-firmware-qcom-rb3gen2 = "file:///PATH/NON-HLOS.bin"
Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
Rb3Gen2 images currently do not install modem firmware even when it is made available through the firmware-qcom-rb3gen2 recipe. Add the modem firmware package to the packagegroup recommendations so it is installed automatically when available. This enables optional modem firmware deployment while preserving the existing configuration. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
QCM6490-IDP images currently do not install modem firmware even when it is made available through the firmware-qcom-qcm6490-idp recipe. Add the modem firmware package to the packagegroup recommendations so it is installed automatically when available. This enables optional modem firmware deployment while preserving the existing configuration. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
Viswanath Kraleti (vkraleti)
force-pushed
the
qcm6490-idp-mdm
branch
from
ef98138 to
7ee8ccc
Compare
Dmitry Baryshkov (lumag)
requested changes
Jul 2, 2026
| S = "${UNPACKDIR}" | ||
|
|
||
| require recipes-bsp/firmware/firmware-qcom.inc | ||
| require recipes-bsp/firmware/firmware-qcom-nhlos.inc |
Contributor
There was a problem hiding this comment.
This is not addressed.
| # NHLOS_URI:pn-firmware-qcom-rb3gen2 = "..." to local.conf. Use "file://" | ||
| # if the file is provided locally. | ||
|
|
||
| DESCRIPTION = "QCOM Firmware for Rb3Gen2 board" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux-firmware.git does not provide modem firmware for QCM6490. However QCM6490-IDP has modem support and for this to work appropriate firmware needs to be included in image. Define an empty placeholder package and by default include it in the packagegroup-qcm6490-idp so that users can override it with vendor provided firmware.