release: harden approval environment validation#183
Open
Simon Beaudoin (simonbeaudoin0935) wants to merge 1 commit into
Open
release: harden approval environment validation#183Simon Beaudoin (simonbeaudoin0935) wants to merge 1 commit into
Simon Beaudoin (simonbeaudoin0935) wants to merge 1 commit into
Conversation
Simon Beaudoin (simonbeaudoin0935)
force-pushed
the
development
branch
from
a4fc929 to
53b5de6
Compare
Validate pkg-release-approval in prepare-release-source and fail when it is missing or has no required reviewers. Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Simon Beaudoin (simonbeaudoin0935)
force-pushed
the
development
branch
from
53b5de6 to
6f58f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the reusable release workflow to strengthen the approval environment gate.
Changes
pkg-release-approvalenvironment check before release proceedsprepare-release-sourcethat are no longer neededType of Change
Additional Context
pkg-exampletargetsqcom-build-utils@developmentfor downstream validation while this is under review.