Repository navigation
Fix controlled GF2MulK decomposition when control is 0 - #1966
Open
rupasri118 wants to merge 2 commits into
Open
rupasri118 wants to merge 2 commits into
rupasri118 wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Updated the controlled GF2 multiplication decomposition to use explicit TwoBitSwap operations for controlled permutations while preserving wire reordering for uncontrolled synthesis. Validation:
|
rupasri118
force-pushed
the
fix-controlled-gf2mulk
branch
from
October 16, 2026 07:05
3924131 to
a4b8900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1951.
The permutation step in
SynthesizeLRCircuitwas implemented using direct Soquet rewiring. WhenGF2MulKwas controlled, this permutation remained unconditional, causing the decomposed circuit to modify the target register even when the control qubit was 0.This change represents the permutation using
TwoBitSwap, making it an explicit Bloq that can be correctly controlled during decomposition.Changes
TwoBitSwapinSynthesizeLRCircuit.GF2MulKdecomposition.ctrl=0leaves the input unchanged.ctrl=1performs multiplication by the specified constant.Testing
test_multiply_by_constant_controlled_decomposition— passedtest_synthesize_lr_circuit— 8 passedgf2_multiplication_test.pyexcluding notebook tests — 78 passed before a long-running test was interrupted.