Add a C++ 'tesseract' namespace.#220
Open
supeterposition wants to merge 1 commit intoquantumlib:mainfrom
Open
Conversation
supeterposition
force-pushed
the
tesseract-namespace
branch
from
e0e6286 to
c545b5b
Compare
Author
LalehB
approved these changes
Mar 23, 2026
Collaborator
LalehB
left a comment
LalehB
left a comment
There was a problem hiding this comment.
LGTM!
super nit suggestion: I would recommend a more descriptive name tesseract_decoder for the namespace, because google has a tesseract OCR engine that has a namespace tesseract :D I doubt that anyone would use both of them together tho!
Contributor
|
Oh yeah +1 to Laleh's suggestion! |
supeterposition
force-pushed
the
tesseract-namespace
branch
from
c545b5b to
3c0b104
Compare
Author
Good idea, done! |
Contributor
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
overall lgtm%nits
This prevents namespace collisions when including C++ headers and libraries.
supeterposition
force-pushed
the
tesseract-namespace
branch
from
3c0b104 to
193affa
Compare
NoureldinYosri
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents namespace collisions when including C++ headers and libraries.