-
Notifications
You must be signed in to change notification settings - Fork 63
"[QEff.finetuning] Adding config_manager and its test cases." #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
quic-akuruvil
merged 15 commits into
quic:ft_experimental
from
tchawada:hf_config_manager
Dec 15, 2025
Merged
"[QEff.finetuning] Adding config_manager and its test cases." #656
quic-akuruvil
merged 15 commits into
quic:ft_experimental
from
tchawada:hf_config_manager
Dec 15, 2025
+915
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
quic-meetkuma
requested changes
Dec 9, 2025
Contributor
quic-meetkuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaner implementation, please fix comments and we will merge it.
Signed-off-by: Tanisha Chawada <[email protected]>
a07b322 to
1f0a4df
Compare
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Signed-off-by: Tanisha Chawada <[email protected]>
Contributor
quic-akuruvil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
quic-akuruvil
added a commit
that referenced
this pull request
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Config_manager to parse the training, model and dataset related arguments.