Add automatic CCL list generation for prefill and decode when user does not provide lists #663
+306
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…ring compilation process Signed-off-by: Vahid Janfaza <[email protected]>
…es not provide lists Signed-off-by: Vahid Janfaza <[email protected]>
vjanfaza
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
…es not provide lists Signed-off-by: Vahid Janfaza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For using CCL feature during prefilling and decoding, the user needs to pass two lists of context lengths to be used during these processes. Here, we add an option to generate these lists automatically when they are not provided by the user manually. These list generation is suitable for a general-purpose application which considers both prefilling and decoding processes and generates CCL lists for both.