Open
Conversation
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Autotools is a relic of the past, let it rot in peace. Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
quic-kdybcio
force-pushed
the
topic/meson
branch
from
bda75f0 to
b642f41
Compare
androm3da
reviewed
Jul 1, 2025
Comment on lines
+1107
to
1109
| return min(available_out, available_in); | ||
| #elif defined (EUD_LNX_ENV) | ||
| return std::min(available_out, available_in); |
There was a problem hiding this comment.
Why are these two defined distinctly from one another on the baseline?
And @quic-kdybcio - why add this difference for EUD_WIN_ENV? How does it fail with std::min() instead?
Aside: we should probably explicitly include stdint.h for the sake of these types. Unless I missed it in there somewhere.
Author
There was a problem hiding this comment.
@androm3da I purposefully touched the questionable code just enough to make it compile.. that said, it's going to need quite some cleanup, if not a rewrite, to be considered maintainable...
Contributor
|
OpenOCD use automake build system. For enabling EUD debug for QCOM chipsets we are adding code submodule in the OpenOCD project. We therefore chose to go with automake for EUD as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meson simplifies dependency management and is much more modern & streamlined.