Skip to content

Fix migration and MCQ data structure - #8

Merged
ehanahamed merged 1 commit into
mainfrom
fix-migration-mcq-correctchoiceindex-1586710462291874154
Jun 27, 2026
Merged

Fix migration and MCQ data structure#8
ehanahamed merged 1 commit into
mainfrom
fix-migration-mcq-correctchoiceindex-1586710462291874154

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

I have corrected the botched version 16 migration and updated the MCQ/PracticeTest data structures as requested.

Key changes:

  1. Interface Updates: MCQ now includes correctChoiceIndex: number and answeredIndex: number | null. PracticeTest now uses questionTermIds and distractorTermIds instead of a combined termIds.
  2. Migration Fix: The version 16 migration now correctly calculates answeredIndex for existing data and splits term IDs into their respective categories (question vs distractor). It also cleans up invalid data by deleting PracticeTest records that lack a mandatory term.
  3. API Layer Improvements: recordPracticeTest, updatePracticeTest, and getPracticeTestsByTermId have been updated. The latter now performs a distinct union query across both new indexes.
  4. Validation: Strict validation has been added to the recording methods to ensure term is always present, throwing an error otherwise.
  5. Testing: Updated the practice test specs to reflect these changes and verified that all 12 tests in the suite pass.

PR created automatically by Jules for task 1586710462291874154 started by @ehanahamed

- Add mandatory `correctChoiceIndex` to `MCQ` interface.
- Replace `answeredTerm` with nullable `answeredIndex` in `MCQ`.
- Split `termIds` in `PracticeTest` into `questionTermIds` and `distractorTermIds`.
- Correct version 16 migration to handle the above changes and ensure data consistency by deleting records with missing term data.
- Update `idbApiLayer` methods to support the new schema and split indexes.
- Update test suite to align with interface changes and verify functionality.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ehanahamed
ehanahamed merged commit e6a37c8 into main Jun 27, 2026
1 check failed
@ehanahamed
ehanahamed deleted the fix-migration-mcq-correctchoiceindex-1586710462291874154 branch June 29, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant