Assert: Return error value from rejects() and throws()#1825
Open
MatmaRex wants to merge 1 commit intoqunitjs:mainfrom
Open
Assert: Return error value from rejects() and throws()#1825MatmaRex wants to merge 1 commit intoqunitjs:mainfrom
MatmaRex wants to merge 1 commit intoqunitjs:mainfrom
Conversation
It permits a more natural way of asserting complex facts about the rejection value (thrown value) than the existing options of sticking assertions inside the `expectedMatcher` or writing your own try…catch blocks. Fixes qunitjs#1824.
|
|
Author
|
I saw those errors locally too: They don't seem to be my fault. |
Member
|
Two CI issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It permits a more natural way of asserting complex facts about the rejection value (thrown value) than the existing options of sticking assertions inside the
expectedMatcheror writing your own try…catch blocks.Fixes #1824.