perf(rule_engine): Move to iterative greedy wildcard matching#549
Merged
rabbitstack merged 1 commit intomasterfrom Dec 27, 2025
Merged
perf(rule_engine): Move to iterative greedy wildcard matching#549rabbitstack merged 1 commit intomasterfrom
rabbitstack merged 1 commit intomasterfrom
Conversation
1883d2d to
d6ef054
Compare
By switching from recursive backtracking to an iterative greedy matcher, we've eliminated: - all the recursion overhead. - repeated slice copies for every recursive call. - exponential branching when * appears in the pattern. The matcher is now linear-time in the length of the pattern and string and introduces the ASCII-fast path with UTF-8 fallback only when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
By switching from recursive backtracking to an iterative greedy matcher, we've eliminated:
The matcher is now linear-time in the length of the pattern and the string, and introduces an ASCII-fast path with a UTF-8 fallback only when needed.
What type of change does this PR introduce?
/kind improvement
Any specific area of the project related to this PR?
/area rule-engine
Special notes for the reviewer
Does this PR introduce a user-facing change?