docs: add dragon q6a vnc login #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EESN-W
requested review from
a team,
RadxaYuntian,
akgnah and
xzuoqi
as code owners
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (3)
-
docs/common/radxa-os/remote-login/_vnc.mdx (246-246)
Using `sudo` to change permissions for a file in the user's home directory is unnecessary and could cause permission issues.
chmod +x ~/.vnc/xstartup -
i18n/en/docusaurus-plugin-content-docs/current/common/radxa-os/remote-login/_vnc.mdx (196-196)
Using `sudo` to edit a file in the user's home directory is unnecessary and could cause permission issues. Since `~/.vnc/xstartup` is in the user's home directory, it should be edited without sudo:
vi ~/.vnc/xstartup -
i18n/en/docusaurus-plugin-content-docs/current/common/radxa-os/remote-login/_vnc.mdx (246-246)
Using `sudo` to change permissions for a file in the user's home directory is unnecessary and could cause permission issues:
chmod +x ~/.vnc/xstartup
💡 To request another review, post a new comment with "/windsurf-review".
i18n/en/docusaurus-plugin-content-docs/current/common/radxa-os/remote-login/_vnc.mdx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/windsurf-review |
Contributor
Author
|
/windsurf-review |
Contributor
There was a problem hiding this comment.
Other comments (4)
-
docs/common/radxa-os/remote-login/_vnc.mdx (194-194)
Using `sudo` to edit a file in the user's home directory is unnecessary and could cause permission issues. The user should already have write permissions to their own ~/.vnc directory:
vi ~/.vnc/xstartup -
docs/common/radxa-os/remote-login/_vnc.mdx (244-244)
Using `sudo` to change permissions on a file in the user's home directory is unnecessary:
chmod +x ~/.vnc/xstartup - docs/common/accessories/_wareshare-spi-lcd-3-5.mdx (78-78) The `fbi` command example uses `logo.bmp` without specifying its path. Consider adding information about where this image should be located or use a more explicit path example to avoid confusion.
- docs/dragon/q6a/accessories/camera-8m-219.md (126-126) There's an inconsistency between adding `libgles2-mesa-dev` as a dependency while removing the `--renderer=gles` parameter from the qcam command. If GLES rendering is no longer being used, consider removing the dependency. If it's still needed, the parameter might need to be kept.
💡 To request another review, post a new comment with "/windsurf-review".
| @@ -0,0 +1,111 @@ | |||
| Use the Waveshare 3.5-inch Raspberry Pi LCD (Waveshare 3.5" RPi LCD (B)) on {props.product}. | |||
Contributor
There was a problem hiding this comment.
There's a typo in the filename: '_wareshare-spi-lcd-3-5.mdx' should be '_waveshare-spi-lcd-3-5.mdx' to match the product name mentioned throughout the document.
| @@ -0,0 +1,111 @@ | |||
| 在 {props.product} 上使用微雪 3.5 寸树莓派显示屏（WareShare 3.5" RPi LCD (B)）。 | |||
Contributor
There was a problem hiding this comment.
There's a typo in the filename and document title. The correct name should be 'Waveshare' instead of 'WareShare'.
| /> | ||
| </div> | ||
| <Image | ||
| src="/img/common/radxa-os/system-config/vnc-#desktop#-succ.webp" |
Contributor
There was a problem hiding this comment.
The image source contains a placeholder #desktop# that won't be properly replaced. Consider using template literals or string interpolation:
Suggested change
| src="/img/common/radxa-os/system-config/vnc-#desktop#-succ.webp" | |
| src={`/img/common/radxa-os/system-config/vnc-${props.desktop}-succ.webp`} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 说明