Add functionality to import and export settings - #20
Conversation
|
This is great work! This will be such a cool feature. While it works just fine now, I think it may use a little polish in the UI. Maybe we can hide the big textarea for users not interested in it and show it when user clicks import or export. I can do that myself, so I'm not expecting that from you. But you can tackle it if you'd like. I created a new branch (export-import) with this feature on the main repo. If we could go on from there that would be perfect. (I could not manage to merge this pull request to a new branch therefore I created it manually and merged it from the git command line). That's why it looks like it is not merged. |
|
Nice! I was thinking of doing this. Can't wait to play with it. |
|
Hi! I just installed this extension from the Firefox addons page, and it works great. I really would like the ability to import / export across machines though. I see that this PR adds that functionality, but it hasn't been touched since 2018. What needs to be done to get this available for release? Is there any development that still needs to be done? I can try and help there. Thanks! |
|
|
||
| function importSettings(event) { | ||
| try { | ||
| var data = JSON.parse(settingsArea.value); |
There was a problem hiding this comment.
| var data = JSON.parse(settingsArea.value); | |
| const data = JSON.parse(settingsArea.value); |
|
|
||
| function exportSettings(event) { | ||
| getSites.then((storage) => { | ||
| var data = { |
There was a problem hiding this comment.
| var data = { | |
| const data = { |
| .blocked-sites button { | ||
| margin-left: 0.5em; | ||
| } | ||
| #settings-area { |
There was a problem hiding this comment.
isn't it better to use css classes as selectors by default?
|
I would like to draw some attention to this issue. This functionality is still needed. |
6 participants
Closes #9
The settings page could probably use a prettier UI, but it's good enough for now.