[justindell]

Any INSERT with a table hint between the table name and the column list fails before it reaches the server:

connection.execute("INSERT INTO books WITH (TABLOCK) (title) SELECT title FROM old_books")
# => ActiveRecord::StatementInvalid: Table 'books WITH' doesn't exist

get_raw_table_name takes everything up to the first (, so the parsed name is books WITH. query_requires_identity_insert? runs on every insert and looks that name up, which raises. WITH (TABLOCK) is the documented way to get a minimally logged INSERT ... SELECT, so right now the only workaround is to go around Active Record.

I fixed it in two places:

• get_raw_table_name strips a WITH (...) hint before reading the table name.
• query_requires_identity_insert? skips past the hint when it looks for the identity column. Without this, an insert with an explicit id still fails with "IDENTITY_INSERT is set to OFF".

INSERT books ... without INTO still isn't handled (it falls through to the FROM branch). I left that out of this PR.

Would you want this backported to 8-1-stable? Happy to open that PR too.

[aidanharan]

Please backport to 8-1. 👍