Repository navigation
Fix yarn berry pnpm linker - #783
Open
fusion2004 wants to merge 1 commit into
Open
fusion2004 wants to merge 1 commit into
fusion2004 wants to merge 1 commit into
Conversation
fusion2004
commented
Oct 10, 2026
| installFolders := []string{"/app/.yarn", p.getYarnBerryGlobalFolder(ctx)} | ||
| if p.getYarnBerryNodeLinker(ctx) == "node-modules" { | ||
| // both the node-modules and pnpm linkers install into node_modules | ||
| if p.getYarnBerryNodeLinker(ctx) != "pnp" { |
Author
There was a problem hiding this comment.
This made sense to me because yarn only supports the 3 linkers:
node-modulespnpmpnp
If you prefer an opt-in, I can switch it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Deploying node apps using yarn berry's pnpm linker fail to run because they can't load any npm packages
Description
Appends the
node_modulesdirectory to the install folders, the same carve-out we have for thenode-moduleslinker. (And the default case, which means that is also howpnpmitself works with railpack.)Test
Added a specific example, like we do for the yarn berry
node-moduleslinker, and ensured integration tests passed.