Prevent the use of Time.now and Time.parse
#247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why we had that cop disabled but it's long been established best practice to use `Time.current` or `Time.zone...` in Rails apps to ensure that everything works regardless of the system time zone. See: https://thoughtbot.com/blog/its-about-time-zones I recently ran into a bunch of these issues when trying to make the specs in the main app pass locally so I guess now I know how those calls made it in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why we had that cop disabled but it's long been established best practice to use
Time.currentorTime.zone...in Rails apps to ensure that everything works regardless of the system time zone. See: https://thoughtbot.com/blog/its-about-time-zonesI recently ran into a bunch of these issues when trying to make the specs in the main app pass locally so I guess now I know how those calls made it in there.
https://www.rubydoc.info/gems/rubocop/0.57.2/RuboCop/Cop/Rails/TimeZone