Fix remaining linter warnings and add gocritic #4349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thardeck
force-pushed
the
fix_remaining_linter_warnings
branch
from
1b80020 to
5ed02c5
Compare
weyfonk
reviewed
Nov 21, 2025
Contributor
weyfonk
left a comment
weyfonk
left a comment
There was a problem hiding this comment.
I am a bit skeptical about this patch: some of it feels a bit like noise to me, although I do like reduced indenting (e.g. collapsing if blocks within else blocks into else if) and appending of values, but renaming variables... the current form of CA and TLS` prefixes, for instance, feels semantically more valuable to me than fixing their possible breaches of naming conventions.
Anyway, as always, happy to discuss :)
|
|
||
| if _, ok := sample.Experiments[experiment]; !ok { | ||
| //fmt.Printf("missing experiment %s\n", name) | ||
| // fmt.Printf("missing experiment %s\n", name) |
Contributor
There was a problem hiding this comment.
... do we really care about a diff like this file's?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few remaining linter warnings and I have added gocritic on top.