-
Notifications
You must be signed in to change notification settings - Fork 37
feat: integrating gemwallet #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/rf-2294-add-xrpl-blockchain
Are you sure you want to change the base?
feat: integrating gemwallet #1096
Conversation
aab72d8 to
2f4d9c5
Compare
e94af17 to
850aef8
Compare
42ee059 to
d2128ef
Compare
fe74821 to
33da16f
Compare
3004875 to
3a71bc0
Compare
6c48259 to
4af8ca1
Compare
48be4fa to
e7beb54
Compare
| value: 'XRPL', | ||
| id: 'XRPL', | ||
| getSupportedChains: (allBlockchains: BlockchainMeta[]) => | ||
| allBlockchains.filter((chain) => chain.name === Networks.XRPL), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you introduce this in the SDK to maintain consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i craeted this pr: rango-exchange/rango-types#55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep this open, I will update this when this pr is about to merge to avoid conflicts with stage.
arlert-armin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ef97cb6 to
eaa569f
Compare
Summary
Implementing GemWallet as our first wallet for XRPL.
Fixes RF-2294
Related PRs
How did you test this change?
Pretty our normal test scenarios for wallets.
Checklist: