Skip to content

Conversation

@yeager-eren
Copy link
Collaborator

@yeager-eren yeager-eren commented Apr 14, 2025

Summary

Implementing GemWallet as our first wallet for XRPL.

Fixes RF-2294

Related PRs

How did you test this change?

Pretty our normal test scenarios for wallets.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@yeager-eren yeager-eren marked this pull request as draft April 14, 2025 16:08
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 3 times, most recently from aab72d8 to 2f4d9c5 Compare June 15, 2025 10:49
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 2 times, most recently from e94af17 to 850aef8 Compare June 16, 2025 09:25
@yeager-eren yeager-eren changed the title wip: integrating gemwallet feat: integrating gemwallet Jun 16, 2025
@yeager-eren yeager-eren marked this pull request as ready for review June 16, 2025 09:27
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 4 times, most recently from 42ee059 to d2128ef Compare June 16, 2025 09:59
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 2 times, most recently from fe74821 to 33da16f Compare June 16, 2025 11:41
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 3 times, most recently from 3004875 to 3a71bc0 Compare July 18, 2025 14:06
@yeager-eren yeager-eren changed the base branch from next to chore/rf-2543-refactor-execute-rango-preset July 18, 2025 14:06
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 2 times, most recently from 6c48259 to 4af8ca1 Compare July 18, 2025 14:48
@yeager-eren yeager-eren force-pushed the feat/integrate-gem-wallet branch 2 times, most recently from 48be4fa to e7beb54 Compare October 13, 2025 06:46
@yeager-eren yeager-eren changed the base branch from next to feat/rf-2294-add-xrpl-blockchain October 13, 2025 06:59
value: 'XRPL',
id: 'XRPL',
getSupportedChains: (allBlockchains: BlockchainMeta[]) =>
allBlockchains.filter((chain) => chain.name === Networks.XRPL),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you introduce this in the SDK to maintain consistency?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i craeted this pr: rango-exchange/rango-types#55

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep this open, I will update this when this pr is about to merge to avoid conflicts with stage.

Copy link
Contributor

@arlert-armin arlert-armin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants