Skip to content

Conversation

@mroeschke
Copy link
Contributor

Description

Aside from the interval tests, I used this prompt to surface these tests

Towards #18659

Removes 154 failing unit tests

Cursor prompt
I want to know if a pytest node ids in the NODEIDS_THAT_FAIL_WITH_CUDF_PANDAS variable in the @conftest-patch.py file tests a private API. A private API is functionality not listed on pandas API reference https://pandas.pydata.org/docs/reference/index.html. A private API can be tested if the assert keyword or functions from the pandas.testing module are used with the private API.

The pandas tests can be found in the /pandas-testing/pandas-tests/tests directory. Only report if the node id in NODEIDS_THAT_FAIL_WITH_CUDF_PANDAS tests a private API. Report finding one subdirectory at a time.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner November 5, 2025 19:52
@mroeschke mroeschke requested review from bdice and wence- November 5, 2025 19:52
@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels Nov 5, 2025
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 5, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Nov 5, 2025
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't that many unique tests. Can you do manual check to see how cursor did if you haven't already?

@mroeschke
Copy link
Contributor Author

There aren't that many unique tests. Can you do manual check to see how cursor did if you haven't already?

Sorry I should have mentioned that I stopped Cursor once it got to the tests/extension directory (I feel like it was starting to lose the original context when moving onto the next directory). I double checked Cursor's results and had to exclude some of its suggestions.

@mroeschke mroeschke requested a review from Matt711 November 6, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants