Skip to content

Conversation

@Matt711
Copy link
Contributor

@Matt711 Matt711 commented Nov 7, 2025

Description

Follow up to #17987. I put the entry in the wrong location.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added the bug Something isn't working label Nov 7, 2025
@Matt711 Matt711 requested a review from a team as a code owner November 7, 2025 19:55
@Matt711 Matt711 added the non-breaking Non-breaking change label Nov 7, 2025
@Matt711 Matt711 requested a review from gforsyth November 7, 2025 19:55
@TomAugspurger
Copy link
Contributor

I think this might be at the wrong spot still. Running actionlint (or pasting the new yaml into https://rhysd.github.io/actionlint/) shows an error from continue-on-error.

❯ actionlint .github/workflows/test.yaml                                                                                                                                                                                                                                                     (base) 
.github/workflows/test.yaml:159:5: when a reusable workflow is called with "uses", "continue-on-error" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "wheel-tests-cudf-polars-with-rapidsmpf" [syntax-check]
    |
159 |     continue-on-error: true
    |     ^~~~~~~~~~~~~~~~~~

jobs.<job_id>.continue_on_error is valid on a normal workflow, but apparently not reusable workflows (yet, https://github.com/orgs/community/discussions/159265)

@Matt711
Copy link
Contributor Author

Matt711 commented Nov 10, 2025

I think this might be at the wrong spot still. Running actionlint (or pasting the new yaml into https://rhysd.github.io/actionlint/) shows an error from continue-on-error.

❯ actionlint .github/workflows/test.yaml                                                                                                                                                                                                                                                     (base) 
.github/workflows/test.yaml:159:5: when a reusable workflow is called with "uses", "continue-on-error" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "wheel-tests-cudf-polars-with-rapidsmpf" [syntax-check]
    |
159 |     continue-on-error: true
    |     ^~~~~~~~~~~~~~~~~~

jobs.<job_id>.continue_on_error is valid on a normal workflow, but apparently not reusable workflows (yet, https://github.com/orgs/community/discussions/159265)

Darn. Thanks for running [action-lint] @TomAugspurger. I wonder if we should add that it as a pre-commit hook?

TomAugspurger added a commit to TomAugspurger/shared-workflows that referenced this pull request Nov 10, 2025
This lets users of the `wheels-test` workflow selectively ignore errors
for workflows that shouldn't block CI, similar to what's offered by
`custom-job`.

The default should be backwards compatible: it's not required, and it
defaults to `false` (i.e. don't continue on errors).

xref rapidsai/cudf#20555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants