[FEA] Update pylibcugraph to support different temporal comparisons #5345
+161
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
feature request
jnke2016
approved these changes
Nov 14, 2025
alexbarghi-nv
requested review from
AyodeAwe and
BradReesWork
and removed request for
a team
ChuckHastings
approved these changes
Nov 18, 2025
rlratzel
requested changes
Nov 19, 2025
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Can you add at least one test that uses the new arguments?
Also, is using strings >, <, etc. as the arg value a common convention that is already familiar to callers? Otherwise, it seems like it would be much more self-documenting to take strings like "strictly_increasing", "monotonically_decreasing", etc. (or some abbreviation of those).
| @@ -1,4 +1,4 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION. | |||
| # SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION. | |||
Contributor
There was a problem hiding this comment.
I don't think this is supposed to be indented?
Member
Author
|
I think that's fair, I'll add a test and change the argument names. |
Member
Author
|
/merge |
2 similar comments
Contributor
|
/merge |
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates pylibcugraph to support different temporal comparisons (i.e. >=, <, <=, >, last).