Skip to content

docs: update docs for changes in noarch builds #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gforsyth wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: update docs for changes in noarch builds #714

gforsyth wants to merge 3 commits into from

Conversation

@gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Dec 10, 2025

  • docs: add note about usage of rapids-package-name in reproducing ci
  • docs: add example of using --noarch flag with rapids-get-pr-artifact

xref rapidai/build-planning#43

@gforsyth gforsyth requested a review from a team as a code owner December 10, 2025 17:58
@gforsyth gforsyth mentioned this pull request Dec 10, 2025
Open
@netlify
Copy link

netlify bot commented Dec 10, 2025 •
edited
Loading

✅ Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 551f16e
🔍 Latest deploy log https://app.netlify.com/projects/docs-rapids-ai/deploys/693c5cf7e963430008a96d00
😎 Deploy Preview https://deploy-preview-714--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

bdice
bdice approved these changes Dec 12, 2025
View reviewed changes
resources/github-actions.md Outdated
**Note:** By default `rapids-get-pr-artifact` uses the most recent commit from the specified PR.
A commit hash from the dependent PR can be added as an optional 4th argument to pin testing to a specific commit.

**Example 3:** Integration testing `cuml` (Python) with a `noarch` build of `cuxfilter`
Copy link
Contributor

@bdice bdice Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a real example. cuML doesn't use cuxfilter. Maybe cudf using dask-cuda? Or something using dask-cudf? There might be better examples.

resources/github-actions.md Outdated
# This ensures that when conda packages are built with strict channel priority enabled,
# the locally-downloaded packages will be preferred to remote packages (e.g. nightlies).
#
RAPIDS_PREPENDED_CONDA_CHANNELS=("${CUXFILTERCHANNEL}")
Copy link
Contributor

@bdice bdice Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RAPIDS_PREPENDED_CONDA_CHANNELS=("${CUXFILTERCHANNEL}")
RAPIDS_PREPENDED_CONDA_CHANNELS=("${CUXFILTER_CHANNEL}")

@gforsyth
Copy link
Contributor Author

gforsyth commented Dec 12, 2025

Updated. Do we just use the merge buttons on this repo?

@jameslamb
Copy link
Member

jameslamb commented Dec 12, 2025

Updated. Do we just use the merge buttons on this repo?

we do:

docs/.github/ops-bot.yaml

Line 4 in 8dfac1a

auto_merger: false

And that file was added only 3 days ago (#713)... before that there wasn't ops-bot.yaml here at all.

Honestly I think we should start using /merge. I don't know of any reason not to here. I'd be happy to approve a PR changing that (or fine with you just pushing a commit here that does that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees

No one assigned

Labels

improvement non-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gforsyth @jameslamb @bdice