Skip to content

Allow CMake v4+ #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jan 6, 2026
Merged

Allow CMake v4+ #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a550b35
allow CMake v4+
trxcllnt Nov 15, 2025
a9222c5
Merge branch 'main' of github.com:rapidsai/rapidsmpf into fix/unconst…
trxcllnt Jan 6, 2026
8183788
fix lint
trxcllnt Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-129_arch-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- clang-tools==20.1.4
- clang==20.1.4
- click >=8.1
- cmake>=3.30.4,<4
- cmake>=3.30.4

@wence- wence- Nov 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We occasionally have to do a dance when a cmake minor/point release is made because something has broken/rapids-cmake needs an update.

Can we upper-bound to currently known working 4.x versions?

@trxcllnt trxcllnt Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this align with the other RAPIDS repos. I think they don't pin to an upper bound because we want to pick up new features, @robertmaynard may have more insight.

@robertmaynard robertmaynard Nov 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I am aware RAPIDS works with any 4.X release so we are safe

@wence- wence- Nov 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous times when we needed to upper bound pin (via cursory search)

With no upper bound pin, on any future date we can arbitrarily break with no forewarning.

Although cmake is not the most frequent culprit here, removing an upper bound pin introduces one more place where it might happen.

@trxcllnt trxcllnt Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the other RAPIDS projects have upper bound pins on CMake, so I don't think this is an issue. If anything breaks, we'll have to add exclusive pins to all RAPIDS projects regardless. Pinning differently here is causing issues when we need to build rapidsmpf with other RAPIDS packages, like what we do in NVAIE. This PR needs to be merged.

@wence- wence- Dec 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the other RAPIDS projects have upper bound pins on CMake, so I don't think this is an issue

I mean, I've pointed out previous times it has been an issue, so I don't know what to do really.

Most recent possible version solving and lack of upper bound pins is the number one reason why rapids CI breaks so regularly.

But I clearly lost this battle long ago, so go ahead. You'll need to find a packaging codeowner to review.

- cuda-cudart-dev
- cuda-cupti-dev
- cuda-nvcc
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-129_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- clang-tools==20.1.4
- clang==20.1.4
- click >=8.1
- cmake>=3.30.4,<4
- cmake>=3.30.4
- cuda-cudart-dev
- cuda-cupti-dev
- cuda-nvcc
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-131_arch-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- clang-tools==20.1.4
- clang==20.1.4
- click >=8.1
- cmake>=3.30.4,<4
- cmake>=3.30.4
- cuda-cudart-dev
- cuda-cupti-dev
- cuda-nvcc
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-131_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- clang-tools==20.1.4
- clang==20.1.4
- click >=8.1
- cmake>=3.30.4,<4
- cmake>=3.30.4
- cuda-cudart-dev
- cuda-cupti-dev
- cuda-nvcc
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ dependencies:
common:
- output_types: [conda, pyproject, requirements]
packages:
- &cmake_ver cmake>=3.30.4,<4
- &cmake_ver cmake>=3.30.4
- ninja
build-cpp:
common:
Expand Down
4 changes: 2 additions & 2 deletions python/librapidsmpf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

[build-system]
Expand Down Expand Up @@ -42,7 +42,7 @@ build-backend = "scikit_build_core.build"
dependencies-file = "../../dependencies.yaml"
matrix-entry = "cuda_suffixed=true"
requires = [
"cmake>=3.30.4,<4",
"cmake>=3.30.4",
"libcudf==26.2.*,>=0.0.0a0",
"librmm==26.2.*,>=0.0.0a0",
"libucxx==0.48.*,>=0.0.0a0",
Expand Down
4 changes: 2 additions & 2 deletions python/rapidsmpf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

[build-system]
Expand Down Expand Up @@ -56,7 +56,7 @@ build-backend = "scikit_build_core.build"
dependencies-file = "../../dependencies.yaml"
matrix-entry = "cuda_suffixed=true"
requires = [
"cmake>=3.30.4,<4",
"cmake>=3.30.4",
"cython>=3.0.3,<3.2.0",
"libcudf==26.2.*,>=0.0.0a0",
"librapidsmpf==26.2.*,>=0.0.0a0",
Expand Down
Loading