[Poc] Use Background pool to get JobInfo from Ray Dashboard #4043
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,58 @@ | ||||||
| package dashboardclient | ||||||
|
|
||||||
| import ( | ||||||
| "sync" | ||||||
|
|
||||||
| cmap "github.com/orcaman/concurrent-map/v2" | ||||||
| ) | ||||||
|
|
||||||
| type WorkerPool struct { | ||||||
| channelContent cmap.ConcurrentMap[string, struct{}] | ||||||
|
||||||
| taskQueue chan func() | ||||||
| stop chan struct{} | ||||||
| wg sync.WaitGroup | ||||||
| workers int | ||||||
| } | ||||||
|
|
||||||
| func NewWorkerPool(taskQueue chan func()) *WorkerPool { | ||||||
|
Collaborator
There was a problem hiding this comment.
Suggested change
Collaborator
There was a problem hiding this comment. Passing a task queue channel is weird. Specifying a worker count is more understandable. You can also make a buffered channel based on the worker count internally. |
||||||
| wp := &WorkerPool{ | ||||||
| taskQueue: taskQueue, | ||||||
| workers: 10, | ||||||
| stop: make(chan struct{}), | ||||||
| channelContent: cmap.New[struct{}](), | ||||||
| } | ||||||
|
|
||||||
| // Start workers immediately | ||||||
| wp.Start() | ||||||
| return wp | ||||||
| } | ||||||
|
|
||||||
| // Start launches worker goroutines to consume from queue | ||||||
| func (wp *WorkerPool) Start() { | ||||||
|
||||||
| for i := 0; i < wp.workers; i++ { | ||||||
| wp.wg.Add(1) | ||||||
| go wp.worker() | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| // worker consumes and executes tasks from the queue | ||||||
| func (wp *WorkerPool) worker() { | ||||||
| defer wp.wg.Done() | ||||||
|
|
||||||
| for { | ||||||
| select { | ||||||
| case <-wp.stop: | ||||||
| return | ||||||
| case task := <-wp.taskQueue: | ||||||
| if task != nil { | ||||||
| task() // Execute the job | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| // Stop shuts down all workers | ||||||
| func (wp *WorkerPool) Stop() { | ||||||
| close(wp.stop) | ||||||
| wp.wg.Wait() | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try not injecting this into the RayJobReconciler? I think it should be an implementation detail of the dashboard client and should be better hidden by the it.