-
Notifications
You must be signed in to change notification settings - Fork 661
feat: upgrade to Ray 2.52.0 to support token auth mode #4152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Ray 2.52.0 to support token auth mode #4152
Conversation
Signed-off-by: Future-Outlier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ryanaoleary
does ray 2.50.1 support label-based scheduling and this PR?
ray-project/ray#57260
(I didn't see this PR mentioned in ray's release note)
I think we should introduce it in kuberay 1.15.0
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @CheyuWu
should we also update the frontend part?
since I am not familiar with it, can you help after the ray's image is confirmed?
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
I don't think Ray 2.50.1 has this change yet: ray-project/ray@e890cd1, it should be in the next release which would be 2.51.0. I think it's only in the nightly image for now. |
This is the default image version used when creating a RayJob. |
|
This part also uses the Ray image version, but it seems that this file is not actually being used. https://github.com/ray-project/kuberay/blob/master/dashboard/src/utils/exampleJobs.ts |
thank you!!! |
…y-image Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
|
Can you update ray-operator/config/samples/ray-cluster.auth.yaml and ray-operator/config/samples/ray-cluster.auth-manual.yaml to use new 2.52.0 image instead of nightly? |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Why are these changes needed?
everywhere including default configs, tests, and samples.
This is for label-based scheduling