[rmodels] Use inverse bind matrices when possible for bind pose in gltf loader#5832
Merged
Merged
Conversation
raysan5
changed the title
Owner
|
@fyl2xp1 Please, could you provide some model for testing those changes? Thanks! |
Owner
|
@JeffM2501 What do you think about this change? |
Contributor
Seems like a good change to me. |
Contributor
Author
|
ctm_sas.zip |
Contributor
Author
|
Bump |
Contributor
|
I will have a look. |
Owner
|
@kimkulling thank you very much Kim! |
Contributor
|
Looks fine for me. |
Owner
|
@fyl2xp1 thanks for the improvement and thanks @JeffM2501 @kimkulling for the further review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix an edge case I've encountered when loading gltf models that provide inverseBindMatrices. Right now raylib ignores them and derives bindPose from the skeleton node hierarchy, which differs in this case.
This patch derives bindPose from inverseBindMatrices when possible, and falls back to the existing path if they aren't provided by the model being loaded.
Tested on Windows using MSVC. Loads both a previously improperly handled model, and a previously working model.