[rcore][RGFW] Fix mg_gamepads_free() iterating freed list nodes#5903
Open
robknopf wants to merge 1 commit into
Open
[rcore][RGFW] Fix mg_gamepads_free() iterating freed list nodes#5903robknopf wants to merge 1 commit into
mg_gamepads_free() iterating freed list nodes#5903robknopf wants to merge 1 commit into
Conversation
Owner
|
@robknopf I'm afraid this reeview should be implemented in RGFW repo or it will be override when updating the library |
mg_gamepads_free() iterating freed list nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
forloop inmg_gamepads_free()capturedcur->prevbefore callingmg_gamepad_release(). If the release mutated or freed the node, the next iteration would follow a stale pointer. Changed to awhileloop that readsgamepads->list.curfresh each iteration.