Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rohilsurana
approved these changes
Feb 4, 2026
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughA refactoring of the SidebarRoot component that transitions from using Collapsible.Root composition to direct aside element rendering with explicit open/closed state management via data-open and data-closed attributes. Includes corresponding updates to CSS selectors, test expectations, and JSDoc annotations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
data-state="expanded"→data-open,data-state="collapsed"→data-closeddata-collapse-disabledinstead ofdata-collapse-disabled="true")Changes
@radix-ui/react-collapsibledependency - component now uses plainuseStatefor state managementCollapsible.Rootprops, now extendsComponentPropsWithoutRef<'aside'>defaultOpen = truedefault valueuseStateinstead of Collapsible wrapperDocs & Tests
[data-open],[data-closed],[data-collapse-disabled])data-closedattribute instead ofdata-state="collapsed"onOpenChangecallback signature remains(open: boolean) => voidSummary by CodeRabbit
true.data-statetodata-open/data-closed.