fix: standardize mode parameter across all APIs #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update client.py to use 'mode' instead of 'device_mode' for consistency - Update device_activity.py to pass 'mode' parameter consistently - All APIs (Device Activity and Order) now use unified 'mode' parameter - Eliminates confusion between 'mode' and 'device_mode' parameters - Maintains backward compatibility through **kwargs pattern
- Update client.py to use device_mode instead of mode parameter - Update device_activity.py method signatures to use device_mode - Update tests to use device_mode consistently - Ensure consistent parameter naming across Device Activity and Order APIs
- Change parameter name from 'mode' to 'device_mode' in _validate_device_mode method - Update docstring and all references for consistency - Ensure complete device_mode parameter standardization
sunnyagg
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.