Disable osmosifying of raw functions#211
Open
samogot wants to merge 1 commit into
Open
Conversation
There is a "feature" that any function passed as one of properties of object parameters to any command is replaced with than command. It is rather inconvenience than handy, because it makes imposible to use contextCallbacks in set command using object syntax. If setting several simple properties can be bypassed, by calling set command several times, using contextCallbacks for nested properties is completely imposible. It is uncertain what was the reason behind such behaviour. It's hard for me imagine where sole than command may be usefull in set or any oter command parameter context. It neither documented, nor covered by tests, so the proposal is to remove this "feature". This may cause some regressions in some existing code that relies on such behaviour (is such code exists), but it will be rather easy to fix by calling then commad explisitly. This commit also fixes rchipka#203 as `type: () => "some string"` now works.
c482a8c to
984bd2c
Compare
Owner
|
I believe the reason is because casting functions as I believe it is necessary and the tests should indicate as much, so if they aren't breaking with your changes they probably should. That being said, the contextCallback functions should still work regardless of being deeply-nested in an object or array, even though they're casted to |
Contributor
Author
|
Sorry, I don't even remember what it was about :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a "feature" that any function passed as one of properties of
object parameters to any command is replaced with than command. It is
rather inconvenience than handy, because it makes imposible to use
contextCallbacks in set command using object syntax. If setting several
simple properties can be bypassed, by calling set command several times,
using contextCallbacks for nested properties is completely imposible.
It is uncertain what was the reason behind such behaviour. It's hard for
me imagine where sole than command may be usefull in set or any oter
command parameter context. It neither documented, nor covered by tests,
so the proposal is to remove this "feature". This may cause some
regressions in some existing code that relies on such behaviour (is such
code exists), but it will be rather easy to fix by calling then commad
explisitly.
This commit also fixes #203 as
type: () => "some string"now works.