[R4_4] Update Thunder for generators backport#2117
Open
sebaszm wants to merge 7 commits into
Open
Conversation
MFransen69
reviewed
May 8, 2026
| mutable uint32_t _referenceCount; | ||
| }; | ||
|
|
||
| template <typename TYPE> |
Contributor
There was a problem hiding this comment.
Haha, that is much smarter then adjusting all code :)
MFransen69
reviewed
May 8, 2026
| } | ||
| Destination& operator=(const Destination& copy) | ||
| { | ||
| if (_callback != nullptr) { |
Contributor
There was a problem hiding this comment.
Not a big issue (and it is a backport anyway but 'officialy' here a check should be done against self assignment, that would (possibly) fail because of the Release. And same for the move above of course
MFransen69
approved these changes
May 8, 2026
VeithMetro
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.