Skip to content

[Actions][R4_4] Add workflows to build Thunder on Linux#2121

Merged
VeithMetro merged 23 commits into
R4_4from
development/actions-r4_4
May 15, 2026
Merged

[Actions][R4_4] Add workflows to build Thunder on Linux#2121
VeithMetro merged 23 commits into
R4_4from
development/actions-r4_4

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

This is a foundation to make workflow to compare the generator's output in ThunderTools on R4_4, same as it is on master.

Few things to note:

  • For now, this workflow is using the development branches with changes to ThunderTools, it needs to be updated when these branches get merged and deleted
  • We need this workflow merged first to be able to build the one in ThunderInterfaces, after it is merged, only then we can uncomment building of ThunderInterfaces here

VeithMetro added 22 commits May 13, 2026 08:50
Comment out ThunderInterfaces job in the workflow.
Updated the branch for push events from 'R4_4' to 'development/actions-r4_4'.
Removed Bluetooth-related build options from the workflow.
Removed Bluetooth support from the build configuration.
Removed the PRIVILEGEDREQUEST option from the build configuration.
Removed HIBERNATESUPPORT option from build configuration.
Comment out various build options for Thunder.
Removed conditional flags for security and coherency in CMake configuration.
Re-enable several build options for Thunder.
Updated the reference for ThunderTools from R4_4 to development/tools-backport and modified the CMake install command to include conditional flags for security and coherency.
Updated the reference branch for the Thunder repository checkout.
Updated the reference in the checkout action for ThunderTools.
Updated comment to indicate future branch change.
Copilot AI review requested due to automatic review settings May 15, 2026 09:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a reusable Linux build workflow (Linux build template.yml) for the R4_4 branch and rewires the existing Build Thunder on Linux.yml to call it. The reusable template builds Thunder across a build_type × shared_libs × architecture matrix (including a 32-bit cross build), pulls in ThunderTools (with optional [DependsOn=...] PR-body overrides), and uploads tar.gz artifacts. ThunderInterfaces invocation is left commented out per the PR description, pending a follow-up workflow in that repo.

Changes:

  • New reusable workflow with apt/PyPI prep, retried installs, optional i386 multilib, and matrix-driven cmake builds.
  • Existing top-level workflow simplified into a thin caller of the new template, scoped to R4_4 (currently a development branch placeholder per a TO-DO).
  • Adds path-ignore for docs/ReleaseNotes and workflow_dispatch; explicit contents: read permissions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/Linux build template.yml New reusable workflow building Thunder for Debug/Release/MinSizeRel × shared/static × 32/64-bit, with retried apt installs, venv-based generator install, and artifact upload.
.github/workflows/Build Thunder on Linux.yml Replaces inline build steps with a call to the new reusable template; updates triggers to R4_4 (placeholder branch), adds workflow_dispatch and docs path-ignore; commented-out ThunderInterfaces follow-up job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/Linux build template.yml
Comment thread .github/workflows/Linux build template.yml
Comment thread .github/workflows/Build Thunder on Linux.yml
Comment thread .github/workflows/Linux build template.yml
Comment thread .github/workflows/Linux build template.yml
Comment thread .github/workflows/Linux build template.yml
@VeithMetro VeithMetro requested a review from sebaszm May 15, 2026 09:16
@VeithMetro VeithMetro merged commit f4b3985 into R4_4 May 15, 2026
13 checks passed
@VeithMetro VeithMetro deleted the development/actions-r4_4 branch May 15, 2026 09:23
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants