RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight by rosemarybennyy · Pull Request #910 · rdkcentral/meta-rdk

rosemarybennyy · 2026-06-03T06:25:51Z

Reason for change: Enable firmware-independent OTA Updates for MemInsight
Test Procedure: Tested and verified
Risks: Low
Priority: P1
Signed-off-by: RoseMary_Benny@comcast.com

Copilot

Pull request overview

Enables firmware-independent OTA update support for MemInsight by updating RDM agent and adding MemInsight packaging metadata plus runtime path handling for app installs under /media/apps.

Changes:

Bump rdmagent recipe version and source revision to pick up updated OTA/app-management behavior.
Add a MemInsight package.json metadata file to the layer and reference it from the MemInsight recipe.
Update start_meminsight.sh to re-point /media/apps/meminsight to a model-specific app directory.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
recipes-support/rdmagent/rdmagent.bb	Bumps `PV` and `SRCREV` to a newer rdm-agent revision.
recipes-devtools/meminsight/meminsight_git.bb	Adds `package.json` to `SRC_URI`.
recipes-devtools/meminsight/files/start_meminsight.sh	Adjusts runtime app path via `/media/apps/meminsight` symlink and reorders variable setup.
recipes-devtools/meminsight/files/package.json	Introduces MemInsight OTA/package metadata including install script reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight
+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight


+SRC_BIN="/media/apps/meminsight/usr/bin/meminsight"
+DST_BIN="/run/meminsight/usr/bin/meminsight"
+RFC_PARAM="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.meminsight.Trigger"


+{
+  "name": "meminsight",
+  "description": "Performance Monitoring tool - meminsight",
+  "version": "1.1",
+  "contents": ["meminsight-pkg.tar"],
+  "size": "72K",
+  "installScript": "/etc/rdm/post-services/start_meminsight.sh"
+}


                   file://meminsight-upload.service \
                   file://meminsight-upload.path \
                   file://upload_MemReports.sh \
+                   file://package.json \
                   "


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

+# Generate RDM package only when 'meminsight' is passed to GENERATE_RDM_CERTS
+# GENERATE_RDM_CERTS can be passed through jenkins or can be set locally in auto.conf
+inherit ${@bb.utils.contains('GENERATE_RDM_CERTS', '${BPN}', 'comcast-package-deploy', '', d)}
+DOWNLOAD_APPS= "${@bb.utils.contains('DISTRO_FEATURES', 'rdm', bb.utils.contains('DISTRO_FEATURES', 'enable_xmeminsight', '', '${BPN}', d), '', d)}"
+CUSTOM_PKG_EXTNS = "dl"


+DOWNLOADABLE_FILES = "${@bb.utils.contains('DOWNLOAD_APPS', '${PKG_BUNDLE_NAME}', '\
+                             ${bindir}/meminsight \
+                             /etc/rdm/post-services/start_meminsight.sh \
+                             ', '', d)}"
+DOWNLOADABLE_FILES += "${@bb.utils.contains('ENABLE_RDM_VERSIONING', 'true', '\
+                             ${sysconfdir}/apps/${PKG_BUNDLE_NAME}_package.json \
+                             ', '', d)}"


+PACKAGE_BEFORE_PN += "${PN}-dl "
+RDEPENDS_${PN} += " ${PN}-dl"
+do_install_append() {
+    if [ "${ENABLE_RDM_VERSIONING}" = "true" ]; then
+        install -d ${D}${sysconfdir}/apps
+        install -m 644 ${WORKDIR}/package.json ${D}${sysconfdir}/apps/${PKG_BUNDLE_NAME}_package.json
+    fi
+}
+FILES_${PN}-dl += "${sysconfdir}/apps/${PKG_BUNDLE_NAME}_package.json \
+                   ${bindir}/meminsight \
+                  /etc/rdm/post-services/start_meminsight.sh \
+                  "
+pkg_postinst_${PN}-dl () {


+APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight
+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight
+
+SRC_BIN="/media/apps/meminsight/usr/bin/meminsight"
+DST_BIN="/run/meminsight/usr/bin/meminsight"
+RFC_PARAM="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.meminsight.Trigger"


+{
+  "name": "meminsight",
+  "description": "Performance Monitoring tool - meminsight",
+  "version": "1.1",
+  "contents": ["meminsight-pkg.tar"],
+  "size": "72K",
+  "installScript": "/etc/rdm/post-services/start_meminsight.sh"
+}


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

@@ -0,0 +1,29 @@
+# Generate RDM package only when 'meminsight' is passed to GENERATE_RDM_CERTS
+# GENERATE_RDM_CERTS can be passed through jenkins or can be set locally in auto.conf
+inherit ${@bb.utils.contains('GENERATE_RDM_CERTS', '${BPN}', 'comcast-package-deploy', '', d)}


+DOWNLOADABLE_FILES = "${@bb.utils.contains('DOWNLOAD_APPS', '${PKG_BUNDLE_NAME}', '\
+                             ${bindir}/meminsight \
+                             /etc/rdm/post-services/start_meminsight.sh \
+                             ', '', d)}"


+APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight
+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight


+{
+  "name": "meminsight",
+  "description": "Performance Monitoring tool - meminsight",
+  "version": "1.1",
+  "contents": ["meminsight-pkg.tar"],


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

+APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight
+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight
+


+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight
+
+SRC_BIN="/media/apps/meminsight/usr/bin/meminsight"


                   file://meminsight-upload.service \
                   file://meminsight-upload.path \
                   file://upload_MemReports.sh \
+                   file://package.json \
                   "


+{
+  "name": "meminsight",
+  "description": "Performance Monitoring tool - meminsight",
+  "version": "1.0.0",
+  "contents": ["meminsight-pkg.tar"],
+  "size": "72K",
+  "installScript": "/etc/rdm/post-services/start_meminsight.sh"
+}
+


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

                   file://upload_MemReports.sh \
+                   file://package.json \
                   "


+APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight
+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight


+SRC_BIN="/media/apps/meminsight/usr/bin/meminsight"
+DST_BIN="/run/meminsight/usr/bin/meminsight"
+RFC_PARAM="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.meminsight.Trigger"


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

                   file://meminsight-upload.path \
                   file://upload_MemReports.sh \
+                   file://package.json \
                   "


+APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight
+rm -rf /media/apps/meminsight
+ln -snf "$APP_HOME_DIR" /media/apps/meminsight


+SRC_BIN="/media/apps/meminsight/usr/bin/meminsight"
+DST_BIN="/run/meminsight/usr/bin/meminsight"
+RFC_PARAM="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.meminsight.Trigger"


Copilot AI review requested due to automatic review settings June 3, 2026 06:25

rosemarybennyy requested review from a team as code owners June 3, 2026 06:25

Copilot started reviewing on behalf of rosemarybennyy June 3, 2026 06:26 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from 61f98cf to 07e0bdb Compare June 4, 2026 05:27

Copilot AI review requested due to automatic review settings June 4, 2026 05:29

Copilot started reviewing on behalf of rosemarybennyy June 4, 2026 05:29 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 4, 2026 06:47

Copilot started reviewing on behalf of rosemarybennyy June 4, 2026 06:47 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from 08819a6 to ea090f9 Compare June 4, 2026 11:13

Copilot AI review requested due to automatic review settings June 4, 2026 11:18

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from ea090f9 to 69d70e8 Compare June 4, 2026 11:18

Copilot started reviewing on behalf of rosemarybennyy June 4, 2026 11:18 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from 69d70e8 to e736481 Compare June 5, 2026 04:53

Copilot AI review requested due to automatic review settings June 5, 2026 09:30

Copilot started reviewing on behalf of rosemarybennyy June 5, 2026 09:30 View session

Copilot AI reviewed Jun 5, 2026

View reviewed changes

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from 1bb6b97 to bad2810 Compare June 9, 2026 06:20

Copilot AI review requested due to automatic review settings June 9, 2026 06:30

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from bad2810 to c679121 Compare June 9, 2026 06:30

Copilot started reviewing on behalf of rosemarybennyy June 9, 2026 06:30 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

rosemarybennyy added 2 commits June 11, 2026 10:11

RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight

a26f7a4

Update package.json

a674a3b

rosemarybennyy force-pushed the topic/RDKEMW-19246 branch from c679121 to a674a3b Compare June 11, 2026 04:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight#910

RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight#910
rosemarybennyy wants to merge 2 commits into
developfrom
topic/RDKEMW-19246

rosemarybennyy commented Jun 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rosemarybennyy commented Jun 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants