RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight#954
Open
rosemarybennyy wants to merge 2 commits into
Open
RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight#954rosemarybennyy wants to merge 2 commits into
rosemarybennyy wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to enable firmware-independent (RDM-managed) OTA delivery for MemInsight by introducing an app-oriented packaging split, systemd units, and helper scripts/config for trigger-based execution and report uploads.
Changes:
- Adds an RDM/firmware-decoupled MemInsight recipe variant with an
${PN}-apppackage split and optional versionedpackage.jsoninstallation. - Introduces a long-running upload sidecar (
upload_MemReports.sh) plus systemd path/service units to trigger it. - Adds post-service logic (
start_meminsight.sh) and systemd drop-in configs to drive MemInsight start via RFC trigger and per-platform path triggers.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-devtools/meminsight/meminsight/meminsight_git.bb | New recipe intended to add RDM/firmware-decoupled packaging + app split for MemInsight |
| recipes-devtools/meminsight/meminsight/files/upload_MemReports.sh | Upload sidecar script that archives and uploads MemInsight reports based on configstore + runtime state |
| recipes-devtools/meminsight/meminsight/files/start_meminsight.sh | Post-service script to stage/copy the MemInsight binary (broadband) and create enable trigger based on RFC value |
| recipes-devtools/meminsight/meminsight/files/package.json | RDM app metadata to support versioned/decoupled delivery |
| recipes-devtools/meminsight/meminsight/files/meminsight-upload.service | systemd unit to run the upload sidecar |
| recipes-devtools/meminsight/meminsight/files/meminsight-upload.path | systemd path unit to trigger the upload sidecar based on a marker file |
| recipes-devtools/meminsight/meminsight/files/meminsight-runner.service | systemd unit to run MemInsight with args sourced from /tmp/meminsight.env |
| recipes-devtools/meminsight/meminsight/files/meminsight-runner.path | base systemd path unit for MemInsight runner (trigger configured via drop-ins) |
| recipes-devtools/meminsight/meminsight/files/conf/client.conf | systemd service drop-in to populate ARGS from TR-181 (client) |
| recipes-devtools/meminsight/meminsight/files/conf/client-path.conf | systemd path drop-in defining client enable marker path |
| recipes-devtools/meminsight/meminsight/files/conf/broadband.conf | systemd service drop-in to populate ARGS from dmcli (broadband) |
| recipes-devtools/meminsight/meminsight/files/conf/broadband-path.conf | systemd path drop-in defining broadband enable marker path (xmeminsight case) |
| recipes-devtools/meminsight/meminsight/files/conf/broadband-rdm-path.conf | systemd path drop-in defining broadband enable marker path (RDM path) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
rosemarybennyy
force-pushed
the
topic/RDKEMW-19246_meminsight
branch
from
2102b92 to
c2e65d6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
recipes-devtools/meminsight/meminsight_git.bb:1
- This change deletes the MemInsight recipe and all associated systemd units/scripts from this layer. As a result, MemInsight will no longer be built or installed from meta-rdk, which seems to contradict the PR goal of “Enable firmware-independent OTA Updates for MemInsight” unless there is a replacement delivery mechanism elsewhere (e.g., moved to another layer/repo or an OTA-managed package that also installs/updates the unit files). Please either (a) add the new/relocated recipe/mechanism in this PR, or (b) update the PR description to explicitly state that MemInsight is being removed from the firmware image and where it is now expected to come from at runtime.
rosemarybennyy
force-pushed
the
topic/RDKEMW-19246_meminsight
branch
from
c2e65d6 to
e975326
Compare
Contributor
|
approved. Please resolve the copilot conversations |
Reason for change: Enable firmware-independent OTA Updates for MemInsight Test Procedure: Tested and verified Risks: Low Priority: P1 Signed-off-by: RoseMary_Benny@comcast.com
Reason for change: Remove meminsight dependencies from meta-rdk Test Procedure: Tested and verified Risks: Low Priority: P1 Signed-off-by: RoseMary_Benny@comcast.com
rosemarybennyy
force-pushed
the
topic/RDKEMW-19246_meminsight
branch
from
e975326 to
0ab10c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Enable firmware-independent OTA Updates for MemInsight
Test Procedure: Tested and verified
Risks: Low
Priority: P1
Signed-off-by: RoseMary_Benny@comcast.com