RDKEMW-6086 : Integrate NativeJS Plugin#6331
Open
gurpreet319 wants to merge 1 commit into
Open
Conversation
gurpreet319
force-pushed
the
topic/RDKEMW-6086
branch
from
8a7d35a to
fb76d59
Compare
madanagopalt
approved these changes
Aug 11, 2025
madanagopalt
previously approved these changes
Aug 12, 2025
anand-ky
requested changes
Aug 12, 2025
| @@ -0,0 +1,8 @@ | |||
| autostart = "false" | |||
| precondition = ["Graphics"] | |||
| callsign = "org.rdk.jsruntime" | |||
Contributor
There was a problem hiding this comment.
can we make the callsign camel cased to match other plugins. So "org.rdk.JSRuntime". Pls refer to https://github.com/rdkcentral/RDKServices?tab=readme-ov-file#coding-guidelines
Author
There was a problem hiding this comment.
Updated the callsign to camel case
|
|
||
| #include "Module.h" | ||
| #include "UtilsLogging.h" | ||
| #include <interfaces/INativeJS.h> |
Contributor
There was a problem hiding this comment.
Can you share interfaces/INativeJS.h source. Is this already part of https://github.com/rdkcentral/ThunderInterfaces/? Was this interface reviewed?
Contributor
|
Is this also planned for RDK-E? Pls get this INativeJS.h interface reviewed by @ramasat |
Reason for change: Integrate the NativeJS Plugin Test Procedure: Refer Ticket Risks: Low Priority: P2
gurpreet319
force-pushed
the
topic/RDKEMW-6086
branch
from
fb76d59 to
4cfb704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Integrate the NativeJS Plugin
Test Procedure: Refer Ticket
Risks: Low
Priority: P2