RDKB-58910, RDKB-60010 : Move the WAN IPV6 configuration from brlan0 by S-Parthiban-Selvaraj · Pull Request #69 · rdkcentral/utopia

S-Parthiban-Selvaraj · 2025-09-18T10:51:32Z

Reason for change:
[NTP] Remove sky specific workarounds from the NTP script .

Test Procedure:
Updated in Jira.

Risks: none
Priority: P1

This PR is dependent on the following related PRs:
rdkcentral/telco-voice-manager#5
#69
rdkcentral/wan-manager#79
rdkcentral/provisioning-and-management#127
rdkcentral/xconf-client#20
rdkcentral/test-and-diagnostic#172
https://github.com/rdk-gdcs/firewall/pull/5
rdkcentral/sysint-broadband#34

Reason for change: [NTP] Remove sky specific workarounds from the NTP script . Test Procedure: Updated in Jira. Risks: none Priority: P1 Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Reason for change: Remove Sky specific workaround from NTP script Test Procedure: None Risks: None Priority: P1 Signed-off-by: Jonathan Wu <Jonathan_Wu@comcast.com>

This reverts commit 7ea7a04.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…/rdkcentral/utopia into feature/wan_Ipv6_address_from_IAPD

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

-        if [ ! -z "$CM_IPV4" ]; then
-             commandString="$commandString -p [$CM_IPV4]:22"
-        fi
    elif [ "$BOX_TYPE" = "WNXL11BWL" ]; then


-   fi

   if [ -n "$WAN_IP" ]; then
       echo "interface listen $WAN_IP" >> $NTP_CONF_TMP


 DHCP_STATIC_HOSTS_FILE=/etc/dhcp_static_hosts
 DHCP_OPTIONS_FILE=/var/dhcp_options
 SelfHealSupport=`sysevent get SelfhelpWANConnectionDiagSupport`
+# LANIPV6Support only used for identifying the ULA usage


Reason for change: Create a /128 Ipv6 address using the received IA_PD Test Procedure: Updated in the JIra Risks: hign Priority: P0 Change-Id: Ic1fa9f5d0b4f0c01fb19de052db555481c78deb0 This PR is dependent on the following related PRs: rdkcentral/telco-voice-manager#5 rdkcentral/utopia#69 rdkcentral/wan-manager#79 rdkcentral/provisioning-and-management#127 rdkcentral/xconf-client#20 rdkcentral/test-and-diagnostic#172 https://github.com/rdk-gdcs/firewall/pull/5 #34 Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> Co-authored-by: Santosh Nayak <70348540+snayak002c@users.noreply.github.com>

) Pull request overview Refactors IPv6 address detection in xb6_firmwareDwnld.sh to consistently use the WAN interface and remove device-/LAN-support-based branching, aligning with the goal of moving WAN IPv6 handling away from brlan0. Changes: Removes LANIPv6GUASupport usage and the associated conditional IPv6 interface-selection logic. Simplifies IPv6 presence detection in getFirmwareUpgDetail() to a single WAN-interface check. Simplifies IPv6 address extraction in the “wait for IP” loop by removing per-box-type branching. Refactor IPv6 address handling in xb6_firmwareDwnld.sh to simplify logic and remove redundant checks This PR is dependent on the following related PRs: rdkcentral/telco-voice-manager#5 rdkcentral/utopia#69 rdkcentral/wan-manager#79 rdkcentral/provisioning-and-management#127 #20 rdkcentral/test-and-diagnostic#172 https://github.com/rdk-gdcs/firewall/pull/5

…172) ## Pull request overview This PR updates self-heal shell scripts to document the current (legacy) use of the `LANIPv6GUASupport` sysevent flag to gate certain WAN/ETH-WAN recovery and connectivity-check behaviors, and adds TODOs calling out the need for a more generic mechanism. **Changes:** - Add explanatory comments describing how `LANIPv6GUASupport` is being interpreted in several self-heal code paths. - Add TODO notes indicating the current DHCP/self-heal approach is outdated and should be refactored away from region/product flags. This PR is dependent on the following related PRs: rdkcentral/telco-voice-manager#5 rdkcentral/utopia#69 rdkcentral/wan-manager#79 rdkcentral/provisioning-and-management#127 rdkcentral/xconf-client#20 #172 https://github.com/rdk-gdcs/firewall/pull/5 ### Reviewed changes Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments. | File | Description | | ---- | ----------- | | scripts/task_health_monitor.sh | Adds comments/TODO around `LANIPv6GUASupport` usage and legacy DHCP self-heal behavior. | | scripts/selfheal_bootup.sh | Adds comments/TODO explaining region-gated ETH WAN failover recovery logic. | | scripts/selfheal_aggressive.sh | Adds comments/TODO explaining region-gated ETH WAN failover recovery logic. | | scripts/self_heal_connectivity_test.sh | Adds comments/TODO explaining use of `LANIPv6GUASupport` to select IPoE-based health checks. | --- 💡 <a href="/rdkcentral/test-and-diagnostic/new/develop?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>. Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> Co-authored-by: Santosh Nayak <70348540+snayak002c@users.noreply.github.com>

…127) Pull Request Overview This PR removes platform-specific workarounds for displaying LAN bridge IPv6 addresses by consolidating different product requirements into a unified approach. The changes eliminate conditional logic that previously handled IPv6 address retrieval differently across various product types (RDKB_GLOBAL_PRODUCT_REQ, HUB4_PRODUCT_REQ). Removed LANIPv6GUASupport sysevent checks and associated conditional logic Consolidated interface selection logic for IPv6 address retrieval Simplified the IPv6 address filtering logic to use a single code path This PR is dependent on the following related PRs: rdkcentral/telco-voice-manager#5 rdkcentral/utopia#69 rdkcentral/wan-manager#79 #127 rdkcentral/xconf-client#20 rdkcentral/test-and-diagnostic#172 https://github.com/rdk-gdcs/firewall/pull/5 --------- Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> Co-authored-by: Jonathan Wu <195466430+jonathanwu-csv@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Santosh Nayak <70348540+snayak002c@users.noreply.github.com>

RDKB-58910, RDKB-60010 : Move the WAN IPV6 configuration from brlan0

2d5a7fe

Reason for change: [NTP] Remove sky specific workarounds from the NTP script . Test Procedure: Updated in Jira. Risks: none Priority: P1 Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk>

This was referenced Sep 18, 2025

RDKB-58910, RDKB-60007 : Use the Ipv6 address set by WanManager rdkcentral/telco-voice-manager#5

Merged

RDKB-58910 : Move the WAN IPV6 configuration from LAN bridge rdkcentral/wan-manager#79

Merged

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

4c17c54

Copilot AI review requested due to automatic review settings November 7, 2025 18:36

Copilot AI reviewed Nov 7, 2025

View reviewed changes

S-Parthiban-Selvaraj mentioned this pull request Nov 11, 2025

RDKB-58910, RDKB-60008 : Move the WAN IPV6 configuration from brlan0 rdkcentral/provisioning-and-management#127

Merged

jonathanwu-csv force-pushed the feature/wan_Ipv6_address_from_IAPD branch from 18a0955 to 98f1db8 Compare November 24, 2025 16:44

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

bfa213f

Copilot AI review requested due to automatic review settings November 24, 2025 20:38

jonathanwu-csv force-pushed the feature/wan_Ipv6_address_from_IAPD branch from 98f1db8 to a20ac26 Compare November 24, 2025 20:38

Copilot AI reviewed Nov 24, 2025

View reviewed changes

RDKB-60010 : Remove sky specific from the NTP script

7ea7a04

Reason for change: Remove Sky specific workaround from NTP script Test Procedure: None Risks: None Priority: P1 Signed-off-by: Jonathan Wu <Jonathan_Wu@comcast.com>

jonathanwu-csv force-pushed the feature/wan_Ipv6_address_from_IAPD branch from a20ac26 to 7ea7a04 Compare November 24, 2025 21:52

Revert "RDKB-60010 : Remove sky specific from the NTP script"

c4fbe7e

This reverts commit 7ea7a04.

Copilot AI review requested due to automatic review settings November 25, 2025 16:58

Copilot AI reviewed Nov 25, 2025

View reviewed changes

jonathanwu-csv and others added 3 commits November 25, 2025 09:00

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

d1d4535

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

b8b390e

revert to older commit to understand the changes

9ba634c

Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk>

S-Parthiban-Selvaraj force-pushed the feature/wan_Ipv6_address_from_IAPD branch 2 times, most recently from a44a4bd to d1e188c Compare January 16, 2026 14:14

Remvoing the use of brlan0 for the Sky platforms

89263a8

Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk>

S-Parthiban-Selvaraj force-pushed the feature/wan_Ipv6_address_from_IAPD branch from d1e188c to 89263a8 Compare January 16, 2026 14:16

S-Parthiban-Selvaraj added 3 commits February 23, 2026 12:57

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

ea15cda

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

3f261cf

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

ccb687c

S-Parthiban-Selvaraj marked this pull request as ready for review April 15, 2026 17:03

S-Parthiban-Selvaraj requested review from a team as code owners April 15, 2026 17:03

Copilot AI review requested due to automatic review settings April 15, 2026 17:03

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

76bfd5a

Copilot started reviewing on behalf of S-Parthiban-Selvaraj April 15, 2026 17:03 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread source/scripts/init/service.d/service_ntpd.sh

LakshminarayananShenbagaraj reviewed Apr 16, 2026

View reviewed changes

Comment thread source/scripts/init/service.d/service_ntpd.sh

S-Parthiban-Selvaraj added 2 commits April 21, 2026 12:33

removing LANIPV6Support dependancy

f40ee81

Merge branch 'feature/wan_Ipv6_address_from_IAPD' of ssh://github.com…

d8dd8ab

…/rdkcentral/utopia into feature/wan_Ipv6_address_from_IAPD

This was referenced Apr 24, 2026

RDKB-58910, RDKB-64627: Move the WAN IPV6 configuration from brlan0 rdkcentral/xconf-client#20

Merged

RDKB-58910, RDKB-64626 : Move the WAN IPV6 configuration from brlan0 rdkcentral/test-and-diagnostic#172

Merged

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

0fe1fd2

Copilot AI review requested due to automatic review settings April 24, 2026 13:19

Copilot started reviewing on behalf of S-Parthiban-Selvaraj April 24, 2026 13:20 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread source/scripts/init/service.d/service_sshd.sh

Comment thread source/scripts/init/service.d/service_ntpd.sh

Comment thread source/scripts/init/service.d/service_ntpd.sh

S-Parthiban-Selvaraj mentioned this pull request Apr 27, 2026

RDKB-64625 : Fix sysint scripts to use generic flow rdkcentral/sysint-broadband#34

Merged

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

e27b67e

hpatel006c approved these changes May 15, 2026

View reviewed changes

snayak002c approved these changes May 15, 2026

View reviewed changes

Merge branch 'develop' into feature/wan_Ipv6_address_from_IAPD

3c07f54

Copilot AI review requested due to automatic review settings May 18, 2026 21:23

Copilot started reviewing on behalf of snayak002c May 18, 2026 21:23 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

snayak002c merged commit 3cb8cbf into develop May 18, 2026
13 of 14 checks passed

github-actions Bot locked and limited conversation to collaborators May 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKB-58910, RDKB-60010 : Move the WAN IPV6 configuration from brlan0#69

RDKB-58910, RDKB-60010 : Move the WAN IPV6 configuration from brlan0#69
snayak002c merged 18 commits into
developfrom
feature/wan_Ipv6_address_from_IAPD

S-Parthiban-Selvaraj commented Sep 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

S-Parthiban-Selvaraj commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

S-Parthiban-Selvaraj commented Sep 18, 2025 •

edited

Loading