RDKB-63242 : Support for iproute2 to create macvlan.#33
Merged
Conversation
Resolving compilation error as below, "error: 'EthLink_DeleteUnTaggedInterface' defined but not used" Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
March 12, 2026 13:44
View session
There was a problem hiding this comment.
Pull request overview
This PR resolves a build warning/error about EthLink_DeleteUnTaggedInterface being defined but unused by compiling that helper only in configurations where it is actually referenced (i.e., when both VLAN HAL options are disabled). This aligns the compilation units with the iproute2/macvlan fallback path used when no VLAN HAL is present.
Changes:
- Wrap the
EthLink_DeleteUnTaggedInterfaceforward declaration with#if !defined(VLAN_MANAGER_HAL_ENABLED) && !defined(COMCAST_VLAN_HAL_ENABLED). - Wrap the
EthLink_DeleteUnTaggedInterfacefunction definition with the same compile-time guard to avoid unused-function diagnostics in HAL-enabled builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolving compilation error as below, "error: 'EthLink_DeleteUnTaggedInterface' defined but not used" Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
guto86
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving compilation error as below,
"error: 'EthLink_DeleteUnTaggedInterface' defined but not used"