fix replacement command invariants - #56
Merged
Merged
Conversation
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rdlabo
marked this pull request as ready for review
August 11, 2026 16:45
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
replacePreparedpreserve the replaced command's queue positionconfirmedValuesat the Kit persistence boundaryWhy
Devin identified two replacement invariants that were not closed by PR #55: replacing a command could orphan companion optimistic state, and a replacement could move behind later commands for the same aggregate. Follow-up review also found that raw product companion rows could overwrite the authoritative confirmed baseline.
The replacement contract is now deliberately narrow: it atomically substitutes the only command for an aggregate, at the same queue position and with the same projection responsibility. Optimistic projections cannot change the confirmed baseline.
Validation
npm run lint -- --quietpassedgit diff --checkpassed