Skip to content

fix: improve error message #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vonovak merged 2 commits into from
Jan 27, 2026
+6 −2
Merged

fix: improve error message #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e773e8
fix: improve error message
vonovak Jan 27, 2026
e7ca75a
Improve error message in funny-buses-invite
vonovak Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/funny-buses-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-native-documents/viewer": patch
---

fix: improve error message
3 changes: 1 addition & 2 deletions packages/document-viewer/ios/RNDocumentViewer.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ - (void)presentPreview:(NSString *)title
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject {
RNDPreviewItem *item = [[RNDPreviewItem alloc] initWithURL:restoredURL title:title];

dispatch_async(dispatch_get_main_queue(), ^{
QLPreviewController *controller = [[RNDPreviewController alloc] initWithPreviewItem:item];
controller.modalPresentationStyle = presentationStyle;
Expand All @@ -85,7 +84,7 @@ - (void)presentPreview:(NSString *)title
}
} else {
[self.presentedUrl stopAccessingSecurityScopedResource];
reject(RNDocViewerErrorUnableToOpenFileType, @"unsupported file", nil);
reject(RNDocViewerErrorUnableToOpenFileType, @"QLPreviewController cannot preview this file. It may not be supported, or deleted.", nil);
}
});
}
Expand Down
Loading